Skip to content

Fix bug in bump_version.sh #10162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: development
Choose a base branch
from
Open

Fix bug in bump_version.sh #10162

wants to merge 1 commit into from

Conversation

davidhorstmann-arm
Copy link
Contributor

@davidhorstmann-arm davidhorstmann-arm commented May 2, 2025 •
edited
Loading

This had not been updated after test_suite_version was moved back to mbedtls from TF-PSA-Crypto.

PR checklist

Please remove the segment/s on either side of the | symbol as appropriate, and add any relevant link/s to the end of the line.
If the provided content is part of the present PR remove the # symbol.

  • changelog not required because: Minor internal fix
  • development PR here
  • TF-PSA-Crypto PR not required because: Issue not in crypto
  • framework PR not required
  • 3.6 PR not required because: Issue not in 3.6
  • tests not required because: Script fix only

@davidhorstmann-arm
Fix bug in bump_version.sh
05027f2 
This had not been updated after test_suite_version was moved back to
mbedtls from TF-PSA-Crypto.

Signed-off-by: David Horstmann <[email protected]>
@davidhorstmann-arm davidhorstmann-arm added needs-review Every commit must be reviewed by at least two team members, needs-ci Needs to pass CI tests needs-reviewer This PR needs someone to pick it up for review size-xs Estimated task size: extra small (a few hours at most) labels May 2, 2025
@davidhorstmann-arm davidhorstmann-arm changed the title Fix bug in bump_version.sh Fix bug in bump_version.sh May 2, 2025
minosgalanakis
minosgalanakis approved these changes May 13, 2025
View reviewed changes
Copy link
Contributor

@minosgalanakis minosgalanakis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@minosgalanakis minosgalanakis minosgalanakis approved these changes

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
needs-ci Needs to pass CI tests needs-review Every commit must be reviewed by at least two team members, needs-reviewer This PR needs someone to pick it up for review size-xs Estimated task size: extra small (a few hours at most)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@davidhorstmann-arm @minosgalanakis