Skip to content

Remove guards for tf-psa-crypto/include/mbedtls conditionals #10171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: development
Choose a base branch
from

Conversation

felixc-arm
Copy link
Contributor

@felixc-arm felixc-arm commented May 12, 2025

Now that Mbed-TLS/TF-PSA-Crypto#247 is merged, the conditionals added in #10122 to account for both scenarios (i.e. when tf-psa-crypto/include/mbedtls exists with files and when it doesn't exist) can be removed.

n.b. Once this is merged, patches in TF-PSA-Crypto will need to be rebased on top of Mbed-TLS/TF-PSA-Crypto#247 to pass the CI. Perhaps it makes sense to wait a bit before merging this patch as it's not an important change and will save extra rebases for PRs that are not based on top of Mbed-TLS/TF-PSA-Crypto#247.
^^ This is probably outdated as it has been long enough that active patches likely would have been rebased for other reasons.

PR checklist

  • changelog not required because: minor internal change
  • development PR provided: HERE
  • TF-PSA-Crypto PR not required because: mbedtls minor change only
  • framework PR not required
  • 3.6 PR not required because: 4.0/1.0 work
  • tests not required because: minor non-functional change

@felixc-arm felixc-arm added needs-review Every commit must be reviewed by at least two team members, needs-ci Needs to pass CI tests needs-reviewer This PR needs someone to pick it up for review size-xs Estimated task size: extra small (a few hours at most) and removed needs-ci Needs to pass CI tests labels May 12, 2025
@felixc-arm felixc-arm force-pushed the remove-public-header-conditionals branch from 79dd1da to c984c09 Compare June 10, 2025 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-review Every commit must be reviewed by at least two team members, needs-reviewer This PR needs someone to pick it up for review size-xs Estimated task size: extra small (a few hours at most)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant