Add wlr.default() to accept custom input data frames #320
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No reason to require the specific class if they provide the correct column names
nanxstats
approved these changes
Apr 10, 2025
LittleBeannie
approved these changes
Apr 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No reason to require the specific class if they provide the correct column names
xref: making progress towards adding a formula argument (#280). This will require
wlr.default()since the whole point is to accept input data frames whose column names do not match the requirements of the classtte_databackground: I had removed
wlr.default()in de83a45 as part of #276 in order to keep it as simple as possible. But at the time I didn't realize we wanted to pass custom input data frames, and requiring the user to manually add the class"tte_data"like we did in our example is unnecessarily tedious.