Add test and reduce namespace requirements for sim_gs_n() with updated bounds
#331
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nanxstats
reviewed
May 28, 2025
There was a problem hiding this comment.
Let's maybe avoid using deprecated testthat APIs when possible? You know we have been using local_edition(3) to switch this at the test level all the time.
usethis::use_testthat(edition = 3) I didn't enable test parallelization because some of our functions run in parallel in the test files.
|
Note that the example I used to create the test does not cover all the code paths. I updated
|
tapply() returns a 1-D array, which is likely fine, but better to be explicit than to rely on R's automatic conversions to do what we expect.
nanxstats
approved these changes
May 29, 2025
There was a problem hiding this comment.
The other code paths look familiar... The gsDesign web interface generates similar code if you switch the "interim and final analysis alpha spending strategy" options in the Update tab.
LittleBeannie
approved these changes
May 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up to PR #324 which enabled updating the bounds in a simulation performed by
sim_gs_n().I used the deprecatedUPDATE: I also migrated to {testthat} edition 3expect_equivalent()because we are still using {testthat} edition 2 (the replacement is only available with edition 3)dplyr::filter()withbase::tapply()anddplyr::group_by()+dplyr::summarize()withbase::tapply(). Note thattapply(summarize = TRUE)returns a 1-D array,but this appears to be sufficient for our use caseUDPATE: And since the test I added doesn't cover all possible code paths, I decided to be cautious and explicitly convert it to a numeric vector withas.numeric()