Skip to content

Reduce runtime of sim_gs_n() examples #332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 29, 2025

Conversation

jdblischak
Copy link
Collaborator

From R CMD check on the latest commit 99f1aed running on Ubuntu with R-devel:

* checking examples ... [34s/36s] OK
Examples with CPU (user + system) or elapsed time > 5s
           user system elapsed
sim_gs_n 15.684  0.388  17.764
* checking examples with --run-donttest ... [37s/41s] OK

To reduce the runtime, I used wrapped most of the tests in \donttest{} (which is what we previously did for sim_fixed_n() in #177).

From `R CMD check`:

```
* checking examples ... [34s/36s] OK
Examples with CPU (user + system) or elapsed time > 5s
           user system elapsed
sim_gs_n 15.684  0.388  17.764
* checking examples with --run-donttest ... [37s/41s] OK
```
@jdblischak jdblischak self-assigned this May 29, 2025
@jdblischak
Copy link
Collaborator Author

Note I had also tried reducing n_sim from 3 to 1 so that more code would be run during the package check, but this wasn't sufficient to reduce the runtime of the examples.

@jdblischak
Copy link
Collaborator Author

I checked the R CMD check results in all 5 CI jobs. None of them flagged the sim_gs_n() examples as long-running.

Copy link
Collaborator

@LittleBeannie LittleBeannie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @jdblischak !

@LittleBeannie LittleBeannie merged commit 08c0364 into Merck:main May 29, 2025
9 checks passed
@jdblischak jdblischak deleted the sim-gs-n-examples-donttest branch May 29, 2025 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants