Skip to content

Multiple Redirection files #3487

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Jul 3, 2025
Merged

Multiple Redirection files #3487

merged 15 commits into from
Jul 3, 2025

Conversation

mikehoffms
Copy link
Collaborator

@mikehoffms mikehoffms commented Jun 24, 2025

Rendered for review:


Redirects to test before merge

Test strategy: test one redir per redir file.

1. .openpublishing.redirection.release-notes.json - empty

2. .openpublishing.redirection.experimental.json - empty

3. .openpublishing.redirection.devtools.json

"source_path": "../microsoft-edge/devtools-guide-chromium/whats-new/2025/06/devtools-137.md",
"redirect_url": "/microsoft-edge/devtools/whats-new/2025/06/devtools-137",

url to test:
https://review.learn.microsoft.com/microsoft-edge/devtools-guide-chromium/whats-new/2025/06/devtools-137?branch=pr-en-us-3487
Status: OK
End up at: https://review.learn.microsoft.com/microsoft-edge/devtools/whats-new/2025/06/devtools-137?branch=pr-en-us-3487

4. .openpublishing.redirection.extensions.json

"source_path": "../microsoft-edge/extensions-chromium/getting-started/part2-content-scripts.md",
"redirect_url": "/microsoft-edge/extensions/getting-started/picture-inserter-content-script",

url to test:
https://review.learn.microsoft.com/microsoft-edge/extensions-chromium/getting-started/part2-content-scripts?branch=pr-en-us-3487
Status: OK
End up at: https://review.learn.microsoft.com/microsoft-edge/extensions/getting-started/picture-inserter-content-script?branch=pr-en-us-3487

5. .openpublishing.redirection.pwa.json

      "source_path": "../microsoft-edge/progressive-web-apps-chromium/experimental-features/index.md",
      "redirect_url": "/microsoft-edge/origin-trials/index",

url to test:
https://review.learn.microsoft.com/microsoft-edge/progressive-web-apps-chromium/experimental-features/index?branch=pr-en-us-3487
https://review.learn.microsoft.com/microsoft-edge/progressive-web-apps-chromium/experimental-features/?branch=pr-en-us-3487
Status: OK
End up at: https://review.learn.microsoft.com/microsoft-edge/origin-trials/?branch=pr-en-us-3487

6. .openpublishing.redirection.webview2.json

      "source_path": "../microsoft-edge/webview2/howto/js.md",
      "redirect_url": "/microsoft-edge/webview2/how-to/javascript",

url to test:
https://review.learn.microsoft.com/microsoft-edge/webview2/howto/js?branch=pr-en-us-3487
Status: OK
End up at: https://review.learn.microsoft.com/microsoft-edge/webview2/how-to/javascript?branch=pr-en-us-3487

7. .openpublishing.redirection.test-automation.json - includes WebDriver

      "source_path": "../microsoft-edge/webdriver-chromium/ie-mode.md",
      "redirect_url": "/microsoft-edge/webdriver/ie-mode",

url to test:
https://review.learn.microsoft.com/microsoft-edge/webdriver-chromium/ie-mode?branch=pr-en-us-3487
Status: OK
End up at: https://review.learn.microsoft.com/microsoft-edge/webdriver/ie-mode?branch=pr-en-us-3487

8. .openpublishing.redirection.web-dev-tips.json - /web-platform/

      "source_path": "../microsoft-edge/devtools-guide-chromium/json-viewer/json-viewer.md",
      "redirect_url": "/microsoft-edge/web-platform/json-viewer",

url to test:
https://review.learn.microsoft.com/microsoft-edge/devtools-guide-chromium/json-viewer/json-viewer?branch=pr-en-us-3487
Status: OK
End up at: https://review.learn.microsoft.com/microsoft-edge/web-platform/json-viewer?branch=pr-en-us-3487

9. .openpublishing.redirection.ide-integration.json

      "source_path": "../microsoft-edge/visual-studio-code/elements-for-edge.md",
      "redirect_url": "/microsoft-edge/visual-studio-code/microsoft-edge-devtools-extension",

url to test:
https://review.learn.microsoft.com/microsoft-edge/visual-studio-code/elements-for-edge?branch=pr-en-us-3487
Status: OK
End up at: https://review.learn.microsoft.com/microsoft-edge/visual-studio-code/microsoft-edge-devtools-extension?branch=pr-en-us-3487

10. .openpublishing.redirection.accessibility.json - empty

11. .openpublishing.redirection.dualengine.json - empty

12. .openpublishing.redirection.privacy.json - leaf node

      "source_path": "../microsoft-edge/privacy-whitepaper/index.md",
      "redirect_url": "https://learn.microsoft.com/legal/microsoft-edge/privacy",

url to test:
https://review.learn.microsoft.com/microsoft-edge/privacy-whitepaper/index?branch=pr-en-us-3487
https://review.learn.microsoft.com/microsoft-edge/privacy-whitepaper/?branch=pr-en-us-3487
Status: OK
End up at: https://review.learn.microsoft.com/legal/microsoft-edge/privacy?branch=main&branchFallbackFrom=pr-en-us-3487

13. .openpublishing.redirection.archived.json - not in TOC

      "source_path": "../microsoft-edge/edgehtml/dev-guide/browser-features/reading-view.md",
      "redirect_url": "/archive/microsoft-edge/legacy/developer",

url to test:
https://review.learn.microsoft.com/microsoft-edge/edgehtml/dev-guide/browser-features/reading-view?branch=pr-en-us-3487
Status: OK
End up at: https://review.learn.microsoft.com/archive/microsoft-edge/legacy/developer/?branch=main&branchFallbackFrom=pr-en-us-3487

14. .openpublishing.redirection.mdn.json - not in TOC

      "source_path": "../microsoft-edge/dev-guide/css/filter-effects.md",
      "redirect_url": "https://developer.mozilla.org/docs/Web/CSS/filter",

url to test:
https://review.learn.microsoft.com/microsoft-edge/dev-guide/css/filter-effects?branch=pr-en-us-3487
Status: OK
End up at: https://developer.mozilla.org/docs/Web/CSS/filter


Redirects to test after merge

Status: OK

https://learn.microsoft.com/microsoft-edge/devtools-guide-chromium/whats-new/2025/06/devtools-137

https://learn.microsoft.com/microsoft-edge/extensions-chromium/getting-started/part2-content-scripts

https://learn.microsoft.com/microsoft-edge/progressive-web-apps-chromium/experimental-features/index
https://learn.microsoft.com/microsoft-edge/progressive-web-apps-chromium/experimental-features/

https://learn.microsoft.com/microsoft-edge/webview2/howto/js

https://learn.microsoft.com/microsoft-edge/webdriver-chromium/ie-mode

https://learn.microsoft.com/microsoft-edge/devtools-guide-chromium/json-viewer/json-viewer

https://learn.microsoft.com/microsoft-edge/visual-studio-code/elements-for-edge

https://learn.microsoft.com/microsoft-edge/privacy-whitepaper/index
https://learn.microsoft.com/microsoft-edge/privacy-whitepaper/

https://learn.microsoft.com/microsoft-edge/edgehtml/dev-guide/browser-features/reading-view

https://learn.microsoft.com/microsoft-edge/dev-guide/css/filter-effects

AB#58089678

@mikehoffms mikehoffms added the cat: general General content. label Jun 24, 2025
@mikehoffms mikehoffms changed the title Multiple Redirection files eg .openpublishing.redirection.devtools.json Multiple Redirection files, eg .openpublishing.redirection.devtools.json Jun 24, 2025
@mikehoffms mikehoffms changed the title Multiple Redirection files, eg .openpublishing.redirection.devtools.json Multiple Redirection files Jun 24, 2025
@mikehoffms mikehoffms marked this pull request as draft June 27, 2025 01:20
@mikehoffms mikehoffms marked this pull request as ready for review June 30, 2025 21:03
Copy link
Contributor

@captainbrosset captainbrosset left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR. I like having these redirects in multiple files a lot more than the giant file.

One question: is the counter (01, 02, .etc) in the filenames useful? If it represents the order of a given area in the current TOC, then we'll have to change it if we change the TOC. For example, if we decide that WebView2 should appear above Progressive Web Apps in the TOC, then we'll need to change two redirect file names.
I'm not the counters are helpful.

One suggestion: consider adding a README.md file inside the /redirects/ folder which explains how the files are organized, and why some of them are empty.

Copy link
Contributor

@captainbrosset captainbrosset left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I also confirm that redirects listed in the top level comment work as expected.

Copy link
Collaborator Author

@mikehoffms mikehoffms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Writer/Editor

@captainbrosset captainbrosset merged commit 120658a into main Jul 3, 2025
2 checks passed
@captainbrosset captainbrosset deleted the user/mikehoffms/redir-files branch July 3, 2025 08:01
captainbrosset added a commit that referenced this pull request Jul 7, 2025
* multi redir files

* redir dir

* move redir dir

* re-populate redir files from "main"

* try 6 spaces before ] like main

* move redir files to root

* trim excess leading spaces

* move devtools redir file into /redirects/

* move devtools redir file to root

* move pwa redir

* move redir files to dir, relative path

* readme

Co-authored-by: Michael Hoffman <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cat: general General content.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants