-
Notifications
You must be signed in to change notification settings - Fork 533
Multiple Redirection files #3487
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the PR. I like having these redirects in multiple files a lot more than the giant file.
One question: is the counter (01, 02, .etc) in the filenames useful? If it represents the order of a given area in the current TOC, then we'll have to change it if we change the TOC. For example, if we decide that WebView2 should appear above Progressive Web Apps in the TOC, then we'll need to change two redirect file names.
I'm not the counters are helpful.
One suggestion: consider adding a README.md file inside the /redirects/ folder which explains how the files are organized, and why some of them are empty.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. I also confirm that redirects listed in the top level comment work as expected.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - Writer/Editor
* multi redir files * redir dir * move redir dir * re-populate redir files from "main" * try 6 spaces before ] like main * move redir files to root * trim excess leading spaces * move devtools redir file into /redirects/ * move devtools redir file to root * move pwa redir * move redir files to dir, relative path * readme Co-authored-by: Michael Hoffman <[email protected]>
Rendered for review:
/devtools-guide-chromium/3d-view/index.md
Redirects to test before merge
Test strategy: test one redir per redir file.
1. .openpublishing.redirection.release-notes.json - empty
2. .openpublishing.redirection.experimental.json - empty
3. .openpublishing.redirection.devtools.json
url to test:
https://review.learn.microsoft.com/microsoft-edge/devtools-guide-chromium/whats-new/2025/06/devtools-137?branch=pr-en-us-3487
Status: OK
End up at: https://review.learn.microsoft.com/microsoft-edge/devtools/whats-new/2025/06/devtools-137?branch=pr-en-us-3487
4. .openpublishing.redirection.extensions.json
url to test:
https://review.learn.microsoft.com/microsoft-edge/extensions-chromium/getting-started/part2-content-scripts?branch=pr-en-us-3487
Status: OK
End up at: https://review.learn.microsoft.com/microsoft-edge/extensions/getting-started/picture-inserter-content-script?branch=pr-en-us-3487
5. .openpublishing.redirection.pwa.json
url to test:
https://review.learn.microsoft.com/microsoft-edge/progressive-web-apps-chromium/experimental-features/index?branch=pr-en-us-3487
https://review.learn.microsoft.com/microsoft-edge/progressive-web-apps-chromium/experimental-features/?branch=pr-en-us-3487
Status: OK
End up at: https://review.learn.microsoft.com/microsoft-edge/origin-trials/?branch=pr-en-us-3487
6. .openpublishing.redirection.webview2.json
url to test:
https://review.learn.microsoft.com/microsoft-edge/webview2/howto/js?branch=pr-en-us-3487
Status: OK
End up at: https://review.learn.microsoft.com/microsoft-edge/webview2/how-to/javascript?branch=pr-en-us-3487
7. .openpublishing.redirection.test-automation.json - includes WebDriver
url to test:
https://review.learn.microsoft.com/microsoft-edge/webdriver-chromium/ie-mode?branch=pr-en-us-3487
Status: OK
End up at: https://review.learn.microsoft.com/microsoft-edge/webdriver/ie-mode?branch=pr-en-us-3487
8. .openpublishing.redirection.web-dev-tips.json - /web-platform/
url to test:
https://review.learn.microsoft.com/microsoft-edge/devtools-guide-chromium/json-viewer/json-viewer?branch=pr-en-us-3487
Status: OK
End up at: https://review.learn.microsoft.com/microsoft-edge/web-platform/json-viewer?branch=pr-en-us-3487
9. .openpublishing.redirection.ide-integration.json
url to test:
https://review.learn.microsoft.com/microsoft-edge/visual-studio-code/elements-for-edge?branch=pr-en-us-3487
Status: OK
End up at: https://review.learn.microsoft.com/microsoft-edge/visual-studio-code/microsoft-edge-devtools-extension?branch=pr-en-us-3487
10. .openpublishing.redirection.accessibility.json - empty
11. .openpublishing.redirection.dualengine.json - empty
12. .openpublishing.redirection.privacy.json - leaf node
url to test:
https://review.learn.microsoft.com/microsoft-edge/privacy-whitepaper/index?branch=pr-en-us-3487
https://review.learn.microsoft.com/microsoft-edge/privacy-whitepaper/?branch=pr-en-us-3487
Status: OK
End up at: https://review.learn.microsoft.com/legal/microsoft-edge/privacy?branch=main&branchFallbackFrom=pr-en-us-3487
13. .openpublishing.redirection.archived.json - not in TOC
url to test:
https://review.learn.microsoft.com/microsoft-edge/edgehtml/dev-guide/browser-features/reading-view?branch=pr-en-us-3487
Status: OK
End up at: https://review.learn.microsoft.com/archive/microsoft-edge/legacy/developer/?branch=main&branchFallbackFrom=pr-en-us-3487
14. .openpublishing.redirection.mdn.json - not in TOC
url to test:
https://review.learn.microsoft.com/microsoft-edge/dev-guide/css/filter-effects?branch=pr-en-us-3487
Status: OK
End up at: https://developer.mozilla.org/docs/Web/CSS/filter
Redirects to test after merge
Status: OK
https://learn.microsoft.com/microsoft-edge/devtools-guide-chromium/whats-new/2025/06/devtools-137
https://learn.microsoft.com/microsoft-edge/extensions-chromium/getting-started/part2-content-scripts
https://learn.microsoft.com/microsoft-edge/progressive-web-apps-chromium/experimental-features/index
https://learn.microsoft.com/microsoft-edge/progressive-web-apps-chromium/experimental-features/
https://learn.microsoft.com/microsoft-edge/webview2/howto/js
https://learn.microsoft.com/microsoft-edge/webdriver-chromium/ie-mode
https://learn.microsoft.com/microsoft-edge/devtools-guide-chromium/json-viewer/json-viewer
https://learn.microsoft.com/microsoft-edge/visual-studio-code/elements-for-edge
https://learn.microsoft.com/microsoft-edge/privacy-whitepaper/index
https://learn.microsoft.com/microsoft-edge/privacy-whitepaper/
https://learn.microsoft.com/microsoft-edge/edgehtml/dev-guide/browser-features/reading-view
https://learn.microsoft.com/microsoft-edge/dev-guide/css/filter-effects
AB#58089678