-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Fix grammar #1749
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Fix grammar #1749
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move "to" to the correct side of "choose".
@jwmsft: This PR passed the acceptance checklist. Please evaluate further and approve/complete the PR if appropriate. Thanks! |
jwmsft
approved these changes
Jun 20, 2019
@EdRands, thanks for submitting this fix. |
QuinnRadich
added a commit
that referenced
this pull request
Aug 9, 2021
* Updated file names * Removed search pattern from the list * Initial PipsPager guidance page * Create PipsPager guidance docs and add images * Expander guidance doc and images * BreadcrumbBar guidance doc and images * Updated docs related to menu and context menu to improve clarity and better define design perspective. * fix typo in metadata, move image above WinUI block * Fix typo, formatting * fix repeated word, formatting * minor edits * Update rounded corner specification to WinUI 2.6 truth (#1340) * Update rounded corner specification to WinUI 2.6 truth * Removed perf comment * Updated to make sense for WinUI 2.6 release * Changed code to update to change made * Updated code sample * Update note section * Update per review feedback * Update menus-and-context-menus.md The page header was weirdly partially duplicated again after "Is this the right control?". I have removed that duplicate content and adjusted the page header sizes to be coherent. * Hyperlinked core occurances of command bar flyout and menu * Update acrylic.md * Update xaml-theme-resources.md * Add Custom Control Styling to XAML Styles page This includes how to best use Lightweight styling resources with custom controls as well as a note around themedictionaries and trying to avoid re-templating controls when possible. * Update timing + easing animation page (#1361) * Initial commit update design contact in header for timing page * Update timing text * Update easing function doc * #31651095, #31650853 (#1385) * #31651095, #31650853 * fix link Co-authored-by: Andrew Glass <[email protected]> * Updated guidance docs to include ImageIcon (#1327) * Updates to Color in Windows apps page (#1384) * Update color.md Quick set of updates. * Update color.md Deleted section about "scoping system colors" because ColorPatelleteResources are no longer compatible with new color system. * Mamatt/animated icon updates (#1460) * Create animated-icon.md * Update animated-icon.md * Update animated-icon.md * Update animated-icon.md * Updates based on feedback. * More updates based on feedback * updated formatting of links * First edit pass complete. Tried to coordinate content with corresonding API topics (#1458) * added to TOC and Icons topic * build warnings * minor clarification * another minor rev Co-authored-by: MarissaMatt <[email protected]> * Kbridge mamatt/animated icon updates missed revs (#1461) * Create animated-icon.md * Update animated-icon.md * Update animated-icon.md * Update animated-icon.md * Updates based on feedback. * More updates based on feedback * updated formatting of links * First edit pass complete. Tried to coordinate content with corresonding API topics (#1458) * added to TOC and Icons topic * build warnings * minor clarification * another minor rev * missed revs Co-authored-by: MarissaMatt <[email protected]> * Starting off preview docs * Adjusting TOC and updating links * Pushing changes to reunion docs, mentioning 0.8 preview * making language more concise * Update horizontal images * Updates * Updating docs with new Preview VSIX story * Some more minor tweaks * Initial edit pass (#1471) * Initial edit pass * PM review * Making changes based on updates to project templates * Added new preview section (#1484) * Context menu updates (round 2) (#1480) * Fixed issue with CommandBar page referencing CommandBarFlyout instead of CommandBarin XCG link * Removed confusing recommendation for using MenuBar in conjunction with CommandBar. * Removed comment about MenuFlyouts "saving space" as this is not the purpose for their use. * Added helpful pointer to collection commanding examples. * Update menus-and-context-menus.md Fix duplicate description Co-authored-by: KB <[email protected]> * Updating list of bug fixes * Adding known issue (unfinished) * Attempts to address feedback from Chigusa (#1487) * attempts to address feedback * review feedback incorporated * Editing with visual studio issue * Adding known issue with color helper * Updating .NET SDKinfo * forgot toc entry * Updating articles based on new preview VSIX * Adding known issue * Changes based on Karl's feedback * Update release-notes-08-preview.md fix build warning * A few last minute tweaks * One more bug fix * Merging latest content updates for 0.8 preview (#1536) * Removed draft preview node (#1537) * Edit pass * Adding some info on new commandbar features * Edit pass * Zaryaf/release reunion 0.8 preview2 (#1539) * Update deploy page Took out architecture info and added in unpackaged app deployment info * New articles 1) architecture article on deployment 2) Install Reunion with links to all the things they would need to install 3) article for checking versions - need to add content (deployment/VSIX) 4) article to remove versions - need to add content (deployment/VSIX) * Update toc.yml Proposal to update toc so all the install and deployment articles are together. * Updated article on remove Added content with image showing how to remove runtime packages * Update "How to check versions" article Included content for checking the runtime version and the console output * Fixing links Added .md at the end of the page links * updated TOC and deployment 1) moved the set up instructions to the install article 2) updated TOC for deployment * fix formatting issue Need to fix indenting that might have caused error. * Fix formatting issues * fix formatting of bullets * POC of reunion release notes * Added release notes to TOC * Moved MRTCore and DWrite core above Deploy in TOC * Updated WinUI release notes * Fixing text hierarchy in release notes * Formatting WinUI namespaces in release notes * Updated VSIX link * Fixed formatting issue with VSIX download button * Removed VSIX placeholders in Chec/remove version articles * Updated titles in runtime architecture doc * Update to deployment architecture content * Testing line break above related topics * Update to deployment section Separated out instructions for testing and IT professionals., and other formatting changes for related content. * Update to workload instructions Restructured instructions so it is by section of the installation dialog instead of by app type. Also remove references to extension in the deployment articles. * Updating VS install instructions * Fixing list formatting of VS instructions * Fixing link for development enviroment * Updates to removal guidance * Updated release notes * Added further details for deployment release notes * Edits to 0.8 Preview content (#1543) Co-authored-by: McLean Schofield <[email protected]> * Users/hickeys/reunion 08p2 (#1545) * Add app lifecycle docs * Update resource packaging note in MRTCore that applies only to reunion 0.5 * Final tweaks to applifecycle articles * Update absolute links to relative * Add app lifecycle docs * Update resource packaging note in MRTCore that applies only to reunion 0.5 * Final tweaks to applifecycle articles * Update absolute links to relative * Change more absolute links to relative * Edits * Fixed links Co-authored-by: McLean Schofield <[email protected]> * More consistency edits for Preview release (#1548) * Fixed warnings (#1549) * Adding new release channels articles (#1550) * WinUI 3 Docs for Reunion May 0.8 Preview (#1542) * Updating TOC for WinUI release notes (#1551) * Moving relnotes around * shortening toc entry * Added notes about preview samples coming soon (#1554) * Added notes about preview samples coming soon * Edit * Adding in unpackaged app tutorial (#1553) * Adding in unpackaged app tutorial * Updating tutorial article * Fix commas * fixing image link * Removing colon after Tutorial and updating date * fixing image url * Moving Deployment tutorial below architecture * Fixing bullet formatting * Content fixes for tutorial * Adding link to DD spec on Github * fix spelling mistake Co-authored-by: McLean Schofield <[email protected]> * Edited new deployment tutorial (#1556) * Changing order of WinUI release notes in TOC (#1557) * Changing toc order * Changing order again * changing order one last time! * Removed empty lines from TOC * Update tutorial-unpackaged-deployment.md (#1561) fix preview version numbers * Update content and images (#1494) * Update content and images * Update image alt-text * Update guidance for breadcrumb bar * Remove extra blank lines * Add BreadcrumbBar to TOC * Shadow article update * Update styles articles * Minor grammer changes * updated wording to remove "read more" pattern * Updated product name references (#1591) * Refactored release channel articles and other improvements (#1592) * Fixed typo * Minor tweak * Updated release channels guidance (#1604) * Fixed links (#1605) * repo sync * Move design section from windows-app-src to hub (#1609) * Update index.md * Update xaml-styles.md * Fix links broken when files were moved (#1610) * Fix links broken when files were moved * Fix two more links * Move files again and update some config files (#1611) * Fixed some build warnings (#1613) * Updating WinUI docs for 0.8 GA (#1612) * Update type ramp * Fixed Project Reunion references (#1616) * Update content and images (#1502) * Update content and images * make links relative * Add to TOC, update metadata description * Make column lengths even * Removed article (#1618) * updates to typography page (#1619) * #31651095 - initial draft * fix link * Cleanup whitespace * Update type ramp image * Ellipsis as default * Swap png for svg * Update images * Delete type ramp png * minor edits, link fix Co-authored-by: Andrew Glass <[email protected]> * DWriteCore release notes (#1620) * edit pass * update 64px to 128px * Customer support & samples (#1623) * Edit pass * align menu flyout in sample code to match image * IA improvements and other updates (#1625) * Updated deployment article (#1626) * move new pages from windows-apps-src to hub * Make absolute links relative * Incorporated team feedback (#1629) * A few more updates for 0.8 docs (#1631) * Update note regarding resource configuration * change list to unordered * fix language slugs * fix underscore in image names * fix underscore in image name * convert HTML tables to markdown * Updated some OS references (#1634) * update titleSuffix metadata to "Windows apps" * move style-related pages to style folder * rename app-bars.md to command-bar.md * rename controls-and-patterns to controls * update links * fix links and images from move * update redirect.json * fix validation warnings * Update depth-shadow.md * Updated articles (#1638) * update depth-shadow.md * TOC and Support (#1640) * TOC and Support 1) Removed 'experimental' from deployment node in TOC. It is already marked in the note. 2) Updated links for Support based on feedback from John. * Removing unnecessary nesting * Proposed restructuring to highlight important release info * delete .db files * add redirect for menus-and-context-menus * Adding specification to known issue (#1641) * Adding specification to known issue * Changing C# to .NET * Doc updates for Reunion 0.8 GA (#1633) * Improved deployment content and some link targets (#1644) * Making updates based on dev review * Fixing CommandBarFlyout * redirecting to generated IWindowNative docs in winapps-win32-api (#1647) * redirecting to generated IWindowNative docs in winapps-win32-api * doc id to false * Last-minute development environment updates (#1648) * Users/hickeys/release cobalt/hickeys updates (#1650) * Add new design docs and images * Add new store docs and images * Fix build warnings * New and updated articles for Design docs (#1649) * Add hello world tutorial * rename file * add 'make apps great' doc * Update InfoBar with right aligned button example * add mention of Expander * Image updates from XCG * add Mica guidance * add missing link * update breadcrumbbar image * minor edit * Update image * rename images to meet guidelines * fix names and links * Winui2.6 releasenotes release cobalt (#1646) * setting up * First draft RN * first draft * added PipsPager and placeholders for other features * minor grammar rev * wrong image * added visual style content * added ImageIcon info * added SplitButton style section * removed popup and added XCG link * remove windows ref * updated content from Ana and revised image refs * updated dates * links * chigusa review * Add Mica information Co-authored-by: Jim Walker (WINDOWS) <[email protected]> * Added some links (#1653) * Revised build availability note (#1654) * Add release note for MRTCore (#1651) * Fixed merge conflicts * Updates for Windows App SDK 1.0 exp release (#1738) * Updated support and servicing (#1739) * Windowing conceptual doc for 1.0 Experimental 1 release (#1745) * Update windowing-overview.md Added more details and provided updated sample code for WinUI interop using C++ and C#. * Update windowing-overview.md Added details about presenters since this is a core concept and something that may not be immediately intuitive. * Update windowing-overview.md Removed the preview reference since that page did not actually exist. :) * Update windowing-overview.md * Update windowing-overview.md Updated the C++ code snippet to reflect latest API changes. * Update windowing-overview.md Incorporated feedback from first team review. * Update windowing-overview.md Updated version naming. Changed sample link to be to the top-level sample directory for now, will add proper link to sample once published. * Update windowing-overview.md Fixed the absolute link for UWP AppWindow to be relative. * minor edits and formatting fixes for windowing doc * Winapp sdk push 1.0 exp1 (#1746) * initial commit * added to toc * removed unpackegd docs * removed toast in overview * added access token rquest and push notification * added COM manifest registration * updated docs per wnp engineer feedback. Added troubleshooting * converted usage to quick start * added nits * renamed troubleshooting * removed required statement * added 8/4 feedback * Users/hickeys/winapp sdk push 1.0 exp1/push notifications (#1742) * First draft of push notification revisions * Fix merge conflicts * Update author metadata * added disclaimers * Edits Co-authored-by: Shawn Hickey <[email protected]> Co-authored-by: McLean Schofield <[email protected]> * Fixing VSIXname (#1747) * Added dynamic dependencies guidance (#1732) * Update with 1.0 Experimental release notes (#1740) * Added back push notifications limitations to exp channel article (#1749) * Edited docs (#1751) * Updating VS version (#1750) * Fixing VSIXname * note about vs support * Clearing up VS confusion * updated links to installer exp-1.0 (#1752) * Small revisions for push notifications articles (#1753) * adding general and Windowing issues (#1755) * Updating package version number (#1759) * Update experimental-channel.md (#1761) * Fixing link in 1.0 exp release notes (#1763) * Fixing link * A few last min changes Co-authored-by: Chigusa Sansen <[email protected]> Co-authored-by: Gabby Bilka <[email protected]> Co-authored-by: Kat <[email protected]> Co-authored-by: My Name <[email protected]> Co-authored-by: Jim Walker <[email protected]> Co-authored-by: Courtney Wales <[email protected]> Co-authored-by: Yulia Klein <[email protected]> Co-authored-by: kikisaints <[email protected]> Co-authored-by: Steven Moyes <[email protected]> Co-authored-by: Andrew Glass <[email protected]> Co-authored-by: Andrew Glass <[email protected]> Co-authored-by: MarissaMatt <[email protected]> Co-authored-by: KB <[email protected]> Co-authored-by: anawishnoff <[email protected]> Co-authored-by: Andrea Courtright <[email protected]> Co-authored-by: Dennis Rea <[email protected]> Co-authored-by: zaryaf <[email protected]> Co-authored-by: Shawn Hickey <[email protected]> Co-authored-by: Mick Alberts <[email protected]> Co-authored-by: AdamBrMSFT <[email protected]> Co-authored-by: QuinnRadich <[email protected]> Co-authored-by: PRMerger20 <[email protected]> Co-authored-by: Steven White <[email protected]> Co-authored-by: Diana Hanson <[email protected]> Co-authored-by: Shannon Leavitt <[email protected]> Co-authored-by: Shawn Hickey <[email protected]> Co-authored-by: PRMerger16 <[email protected]> Co-authored-by: Shana McKibbin <[email protected]> Co-authored-by: PRMerger9 <[email protected]> Co-authored-by: Roberth Karman <[email protected]> Co-authored-by: Nicu Parente <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move "to" to the correct side of "choose".