Skip to content

Update composition-effects.md #1768

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

embender
Copy link

No description provided.

@PRMerger17
Copy link
Contributor

@embender : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@Kellylorenebaker
Copy link
Contributor

@jwmsft : : The PR passed the acceptance checklist.

Note that our style is sentence case, so unless these captialization changes reflect proper names, we should retain the lowercase structure.

Please evaluate further and approve/complete the PR if appropriate. Thanks!

@Jak-MS Jak-MS added the aq-pr-triaged tracking label for the PR review team label Jul 11, 2019
@jwmsft
Copy link
Contributor

jwmsft commented Oct 21, 2019

As noted previously, we should typically use sentence case. I'll check this section of the Composition docs to make sure we're being consistent, and make any updates that are needed in a new PR.

@jwmsft jwmsft closed this Oct 21, 2019
QuinnRadich pushed a commit that referenced this pull request Aug 11, 2021
Without FileTypeFilter, the code results in System.Runtime.InteropServices.COMException: 'Error HRESULT E_FAIL has been returned from a call to a COM component.'
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
aq-pr-triaged tracking label for the PR review team Change sent to author do-not-merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants