Skip to content

Update attached-properties-overview.md #3125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Update attached-properties-overview.md #3125

wants to merge 1 commit into from

Conversation

jaigak
Copy link
Contributor

@jaigak jaigak commented May 18, 2021

Fixes indentation for C#, VB and C++/CX. Also removes dev langs as they were not working correctly and just shows the examples in all the languages by default.

Copy link
Contributor

@jwmsft jwmsft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Jaiganeshkumaran, thanks for helping us fix these code samples. The devlangs need to exactly match the code blocks in the doc, so the correct fix here is to update the code blocks from cpp to cppcx, and update the devlangs to:

dev_langs:
  - csharp
  - vb
  - cppwinrt
  - cppcx

Thanks

@ktoliver
Copy link
Contributor

ktoliver commented Sep 3, 2021

It looks like the working branch that was used to create the pull request has been deleted, so a commit can't be added to the pull request. We'll close the PR. Please create a new pull request to update the article per the author's feedback. Thanks.

@ktoliver ktoliver closed this Sep 3, 2021
QuinnRadich added a commit that referenced this pull request Nov 7, 2022
Co-authored-by: Jaiganésh Kumaran <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants