Include keyboard accelerators in tooltips #3511
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Recommend including keyboard accelerators in tooltips, and use a more realistic example
|
@mcooley : Thanks for your contribution! The author(s) have been notified to review your proposed change. |
|
#label:"aq-pr-triaged" |
jwmsft
approved these changes
Jan 18, 2022
|
#sign-off |
learn-build-service-prod bot
added a commit
that referenced
this pull request
Apr 6, 2023
…c_temp For protected CLA branch, push strategy should use PR and merge to target branch method to work around git push error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The keyboard accelerators documentation includes a section on tooltips, but the tooltips documentation doesn't say anything about keyboard accelerators. Add a suggestion that when you override the default behavior, you should probably include information about keyboard accelerators so that users can discover them.
Also, the first tooltip in the article ("Click to submit") doesn't follow our recommendation: "Don't make it obvious or just repeat what is already on the screen.". I changed this to "Create a new document", which is a more realistic example where a tooltip might be needed to provide supplemental information.