Add actor concurrency model(similar to Elixir) #17214
Open
+575
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glyh
changed the title
glyh
force-pushed
the
corvo/actor-2
branch
9 times, most recently
from
892ba18 to
928e19f
Compare
|
!ci-build-me |
|
!ci-bypass-changelog |
|
NVM, somehow rerun CI fixed the issue. |
|
!ci-build-me |
|
!ci-build-me |
glyh
commented
May 19, 2025
| MNext state | ||
| | RExit resp -> | ||
| (* NOTE: for some reason OCaml can't infer this type here *) | ||
| Ivar.fill response_ivar (Obj.magic resp) ; |
There was a problem hiding this comment.
Unfortunately OCaml can't infer the type here :(
glyh
commented
May 20, 2025
|
!ci-build-me |
glyh
commented
May 20, 2025
georgeee
reviewed
May 20, 2025
|
Added all descriptions in a interface file. |
|
!ci-build-me |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Next in train: #17224
NOTE: CI Nightly is passing in the last PR in this train: #17225
NOTE2: This indeed needs careful review, I've spotted several bugs already.
Purpose
This is Actor model, going to be used to refactor transition router. Well, not strictly because it also supports a server model where an actor could process requests and return responses.
Potential Improvements
For now we only have 3 inboxes for an Actor:
request,controlanddata, in that priority order.requestsupport handling dependently typed requests defined by GADTs.controlis just a normal queue that never drops any messages.datais supposed to partially simulatestrict_pipe's behavior.This model could be generalized to any number of channels. Utilizing Heterogeneous Lists. This could further be refactored using a heterogeneous priority queue so messages can have customized priority. But it seems for now we don't have a good use case of such actor.
Benefits
Hooking into an actor
If everything is modeled as actor, we could design a supervisor system by hooking into Actor implementation, and then we can have a good flamegraph implementation knowing at which time, which actor is running.
Inspecting an actor
You could just look into the struct to inspect what messages in queue an actor has, and its state. Previously all such abstraction is inside lambda functions -- You just can't identify an lambda without some quirks I guess.
Mitigate concurrency issues
The very reason I'm trying to introduce this is
Transition_routerhas some nasty synchronization bugs, I haven't been able to figure out the fix even knowing the issue. One of the blockers is that there's virtually no good way to debugAsynccode due to everything being lambda, and abusingdon't_wait_formade the code worse.