Skip to content

Merge compatible to develop (20 May 2025) #17226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 46 commits into from
May 21, 2025
Merged
Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
46 commits
Select commit Hold shift + click to select a range
c614ab9
Submodules/crypto: bump up proof-systems
dannywillems May 6, 2025
05e3d57
Rust: use 1.81.0 and nightly-2024-09-05
dannywillems May 6, 2025
4f86cfc
Dockerfile: wasm-pack is now a dependencies in proof-systems
dannywillems May 6, 2025
9b8f16c
Dockerfile: remove installation of wasm-pack
dannywillems May 6, 2025
b7b6572
Dockerfile: install cargo-xtask
dannywillems May 6, 2025
ca91b4b
Dockerfile: wrap long lines at 80 chars
dannywillems May 6, 2025
a82c2d5
Buildkite: bump up toolchain images
dannywillems May 6, 2025
6854f5c
Bump up proof-systems
dannywillems May 12, 2025
81b7f46
Move deprecated value out of schnorr
cjjdespres May 12, 2025
613d7d4
Merge branch 'compatible' into dw/bump-up-to-rust-1.81
dannywillems May 13, 2025
fd1477d
Merge pull request #17171 from MinaProtocol/compiled-signature-kind-s…
georgeee May 13, 2025
7c656f8
Move deprecated value out of account update
cjjdespres May 13, 2025
ea1ed82
Merge pull request #17187 from MinaProtocol/compiled-signature-kind-a…
dannywillems May 14, 2025
6e3b5ff
Merge pull request #17156 from MinaProtocol/dw/bump-up-to-rust-1.81
dannywillems May 15, 2025
a1ab503
Snark Work Lib: order dune dependencies alphabetically
glyh May 15, 2025
80eb694
Merge pull request #17193 from MinaProtocol/corvo/dummy-1
dannywillems May 15, 2025
5970574
Mina Stdlib: Add Time.Span -- yojsonable, sexpable time span
glyh May 16, 2025
47837de
UNCOMPIABLE Ledger Proof: lift Prod to top level so there's only one …
glyh May 16, 2025
545a67e
Propagate change of Ledger Proof API around the codebase
glyh May 16, 2025
01cf031
Ledger Proof: remove function {sok_digest, Cached.sok_digest}, unused
glyh May 16, 2025
3b81567
Snarked Ledger State: implement Full.Poly.drop_sok
glyh May 16, 2025
e193bdf
Snark Work Lib: factor out Result_without_metrics
glyh May 16, 2025
4d1096a
Snark Work Lib: add interface for Result_without_metrics
glyh May 16, 2025
f1257d5
Add tests for Time.Span.V1 json
georgeee May 16, 2025
053c146
Merge pull request #17201 from MinaProtocol/corvo/snark-work-libmove-…
glyh May 16, 2025
0c3cf11
Merge pull request #17200 from MinaProtocol/corvo/snarked-ledger-stat…
glyh May 16, 2025
7392381
Merge pull request #17196 from MinaProtocol/corvo/remove-ledger-proof…
glyh May 16, 2025
bd0d537
Snark Worker: collect all structured log events in a new module
glyh May 16, 2025
1c3376c
Merge pull request #17195 from MinaProtocol/corvo/mina-stdlib-time
glyh May 16, 2025
d256b17
Snark Work Lib: track single spec(Poly/Selector) in a self contained …
glyh May 16, 2025
090a601
Snark Work Lib: write a notice on these file would be removed finally
glyh May 16, 2025
5bc0ef7
Snark Work Lib: create interface for Single Spec
glyh May 16, 2025
3a5b776
Work Partitioner: set up library
glyh May 16, 2025
0546f65
Merge pull request #17198 from MinaProtocol/corvo/ledger-proof-drop-s…
glyh May 16, 2025
0861531
Merge pull request #17203 from MinaProtocol/corvo/snark-worker-collec…
glyh May 16, 2025
1c25814
Merge pull request #17205 from MinaProtocol/corvo/setup-work-partitioner
glyh May 16, 2025
4cad6b7
Merge pull request #17204 from MinaProtocol/corvo/snark-work-lib-sing…
glyh May 16, 2025
afb7131
pickles/gen_scalars: remove dead code
marcbeunardeau88 May 6, 2025
6284b4c
pickles/gen_scalars: remove empty index_terms
marcbeunardeau88 May 6, 2025
e35861c
Makefile: add a target for `cargo vendor kimchi-stubs-vendors`
anne-laure-s May 16, 2025
1dbc934
Merge pull request #17159 from MinaProtocol/marc/pickles-remove-dead-…
marcbeunardeau88 May 16, 2025
63e5b7b
Merge pull request #17208 from MinaProtocol/al/makefile
dannywillems May 16, 2025
af790c8
Merge branch 'dkijania/once_again_fix_rosetta' into dkijania/port_ros…
dkijania May 19, 2025
b8da255
revert mesh -> rosetta
dkijania May 16, 2025
8535670
Merge pull request #17219 from MinaProtocol/dkijania/port_rosetta_fix…
dkijania May 19, 2025
b4dd834
Merge remote-tracking branch 'origin/compatible' into HEAD
georgeee May 20, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
48 changes: 2 additions & 46 deletions src/lib/pickles/plonk_checks/gen_scalars/gen_scalars.ml
Original file line number Diff line number Diff line change
Expand Up @@ -113,8 +113,6 @@ end

module type S = sig
val constant_term : 'a Env.t -> 'a

val index_terms : 'a Env.t -> 'a Lazy.t Column.Table.t
end

(* The constraints are basically the same, but the literals in them differ. *)
Expand Down Expand Up @@ -150,32 +148,11 @@ module Tick : S = struct
external fp_linearization : unit -> string * (string * string) array
= "fp_linearization_strings"

let fp_constant_term, fp_index_terms = fp_linearization ()
let fp_constant_term, _fp_index_terms = fp_linearization ()

let () = output_string fp_constant_term

let () =
output_string
{ocaml|

let index_terms (type a) (_ : a Env.t) =
Column.Table.of_alist_exn
[
|ocaml}

let is_first = ref true

let () =
Array.iter fp_index_terms ~f:(fun (col, expr) ->
if !is_first then is_first := false else output_string " ;\n" ;
output_string "(" ;
output_string col ;
output_string ", lazy (" ;
output_string expr ;
output_string "))" )

let () = output_string {ocaml|
]
end
|ocaml}

Expand Down Expand Up @@ -214,31 +191,10 @@ module Tock : S = struct
external fq_linearization : unit -> string * (string * string) array
= "fq_linearization_strings"

let fq_constant_term, fq_index_terms = fq_linearization ()
let fq_constant_term, _fq_index_terms = fq_linearization ()

let () = output_string fq_constant_term

let () =
output_string
{ocaml|

let index_terms (type a) (_ : a Env.t) =
Column.Table.of_alist_exn
[
|ocaml}

let is_first = ref true

let () =
Array.iter fq_index_terms ~f:(fun (col, expr) ->
if !is_first then is_first := false else output_string " ;\n" ;
output_string "(" ;
output_string col ;
output_string ", lazy (" ;
output_string expr ;
output_string "))" )

let () = output_string {ocaml|
]
end
|ocaml}
6 changes: 0 additions & 6 deletions src/lib/pickles/plonk_checks/scalars.ml
Original file line number Diff line number Diff line change
Expand Up @@ -101,8 +101,6 @@ end

module type S = sig
val constant_term : 'a Env.t -> 'a

val index_terms : 'a Env.t -> 'a Lazy.t Column.Table.t
end

(* The constraints are basically the same, but the literals in them differ. *)
Expand Down Expand Up @@ -3379,8 +3377,6 @@ module Tick : S = struct
field
"0x0000000000000000000000000000000000000000000000000000000000000000"
)

let index_terms (type a) (_ : a Env.t) = Column.Table.of_alist_exn []
end

module Tock : S = struct
Expand Down Expand Up @@ -4227,6 +4223,4 @@ module Tock : S = struct
* cell (var (Witness 3, Curr))
* cell (var (Witness 4, Curr))
+ cell (var (Coefficient 9, Curr)) ) )

let index_terms (type a) (_ : a Env.t) = Column.Table.of_alist_exn []
end
2 changes: 0 additions & 2 deletions src/lib/pickles/step_verifier.ml
Original file line number Diff line number Diff line change
Expand Up @@ -784,8 +784,6 @@ struct
(Shifted_value.Type1)
(struct
let constant_term = Plonk_checks.Scalars.Tick.constant_term

let index_terms = Plonk_checks.Scalars.Tick.index_terms
end)
end

Expand Down
2 changes: 0 additions & 2 deletions src/lib/pickles/wrap.ml
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,6 @@ module Type1 =
(Shifted_value.Type1)
(struct
let constant_term = Plonk_checks.Scalars.Tick.constant_term

let index_terms = Plonk_checks.Scalars.Tick.index_terms
end)

let _vector_of_list (type a t)
Expand Down