Skip to content
This repository was archived by the owner on Jan 30, 2023. It is now read-only.

Added Linux & macOS Support. #12

Open
wants to merge 14 commits into
base: master
Choose a base branch
from
Open

Conversation

TURX
Copy link

@TURX TURX commented Jan 12, 2019

I can now use Mono to launch Minecraft after applying these little modifications.
Thank you for reviewing my code!

@TURX
Copy link
Author

TURX commented Jan 12, 2019

The CI build failed because I am using NuGet package DotNetZip to deal with zip files.

@ZhaiSoul
Copy link
Contributor

If you wanna get Linux OS Java list, you can use 'whereis java' common.
Please reformat your code and make the alignment the same as the original code.
Don't change AssemblyName.
Have nice day :D

@kblackcn
Copy link
Member

The CI build failed because I am using NuGet package DotNetZip to deal with zip files.

I'm the initial developer. There is a reason why this library doesn't support *nix.

We all want to embrace the latest technology such as .net core and the outdated framework is undoubtedly annoying when developing. However, you will find that its framework version is "v4.0". It's the last version that is supported on Windows XP and Supporting Windows XP is actually an important feature. Although Windows XP's market share in China has decreased a lot in recent years, there are still many Windows 7 machines in China that is "optimized", which makes an upgrading .net version very difficult. The reason to avoid NuGet is the objective to produce a single binary. To sum up, nearly everything that outdated is to meet the fundamental realities of the country.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants