Feature/correct splitter #288
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #288 +/- ##
===========================================
Coverage 100.00% 100.00%
===========================================
Files 45 78 +33
Lines 2242 5335 +3093
===========================================
+ Hits 2242 5335 +3093 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
blondered
reviewed
Jul 1, 2025
| @@ -1,4 +1,4 @@ | |||
| # Copyright 2023-2024 MTS (Mobile Telesystems) | |||
- Fixed `LasNSplitter` class.
blondered
reviewed
Jul 7, 2025
| @@ -5,10 +5,14 @@ All notable changes to this project will be documented in this file. | |||
| The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/), | |||
| and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html). | |||
|
|
|||
| ## Unreleased | |||
| ## [Unreleased] | |||
There was a problem hiding this comment.
Brackets are only for release versions
| ### Added | ||
| - `extras` argument to `SequenceDataset`, `extra_cols` argument to `TransformerDataPreparatorBase`, `session_tower_forward` and `item_tower_forward` methods to `SimilarityModuleBase` ([#287](https://github.com/MobileTeleSystems/RecTools/pull/287)) | ||
|
|
||
| ### Fixed | ||
|
|
||
| - [Breaking] Now `LastNSplitter` class guarantees correct splitting in case of identical timestamps ([#288](https://github.com/MobileTeleSystems/RecTools/pull/288)) |
There was a problem hiding this comment.
Suggested change
| - [Breaking] Now `LastNSplitter` class guarantees correct splitting in case of identical timestamps ([#288](https://github.com/MobileTeleSystems/RecTools/pull/288)) | |
| - [Breaking] Now `LastNSplitter` guarantees taking the last ordered interaction in dataframe in case of identical timestamps ([#288](https://github.com/MobileTeleSystems/RecTools/pull/288)) |
| @@ -1,4 +1,4 @@ | |||
| # Copyright 2023-2024 MTS (Mobile Telesystems) | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Type of change
How Has This Been Tested?
Before submitting a PR, please check yourself against the following list. It would save us quite a lot of time.