Skip to content

Adding more export tests #13410

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 17 commits into from
May 6, 2025
Merged

Adding more export tests #13410

merged 17 commits into from
May 6, 2025

Conversation

oyilmaz-nvidia
Copy link
Collaborator

Important

The Update branch button must only be pressed in very rare occassions.
An outdated branch is never blocking the merge of a PR.
Please reach out to the automation team before pressing that button.

What does this PR do ?

Adds more export tests to get more coverage.

@oyilmaz-nvidia oyilmaz-nvidia added the r2.3.0 Pick this label for auto-cherrypicking into v2.3.0 label May 2, 2025
Copy link
Contributor

github-actions bot commented May 2, 2025

[🤖]: Hi @oyilmaz-nvidia 👋,

We wanted to let you know that a CICD pipeline for this PR just finished successfully.

So it might be time to merge this PR or get some approvals.

Due to a major CI change, merges are currently handled by the automation team.
We will reach out to you quickly to merge this PR, but you can always reach us with the following handles:

//cc @chtruong814 @ko3n1g @pablo-garay @thomasdhc

Copy link
Collaborator

@ko3n1g ko3n1g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last commit only moves those tests to GPU and removes critical import. Should be fine to fast-merge

@ko3n1g ko3n1g merged commit 973de38 into main May 6, 2025
48 of 53 checks passed
@ko3n1g ko3n1g deleted the onur/more-more-export-tests branch May 6, 2025 00:03
ko3n1g added a commit that referenced this pull request May 6, 2025
* Tests for vLLMHFExporter and TensorRT lazy compiler

Signed-off-by: Onur Yilmaz <[email protected]>

* Adding sentencepiece tokenizer test for export

Signed-off-by: Onur Yilmaz <[email protected]>

* More unit tests for tensorrt_llm.py

Signed-off-by: Onur Yilmaz <[email protected]>

* more tensorrt_mm_exporter tests

Signed-off-by: Onur Yilmaz <[email protected]>

* Fix style

Signed-off-by: Onur Yilmaz <[email protected]>

* Add header

Signed-off-by: Onur Yilmaz <[email protected]>

* Apply isort and black reformatting

Signed-off-by: oyilmaz-nvidia <[email protected]>

* new tests for lora and export utils

Signed-off-by: Onur Yilmaz <[email protected]>

* Apply isort and black reformatting

Signed-off-by: oyilmaz-nvidia <[email protected]>

* Fix some of the codeql issues

Signed-off-by: Onur Yilmaz <[email protected]>

* Add header

Signed-off-by: Onur Yilmaz <[email protected]>

* Marking tests as GPU only

Signed-off-by: Onur Yilmaz <[email protected]>

---------

Signed-off-by: Onur Yilmaz <[email protected]>
Signed-off-by: oyilmaz-nvidia <[email protected]>
Co-authored-by: oyilmaz-nvidia <[email protected]>
Co-authored-by: oliver könig <[email protected]>
chtruong814 pushed a commit that referenced this pull request May 6, 2025
* Tests for vLLMHFExporter and TensorRT lazy compiler

Signed-off-by: Onur Yilmaz <[email protected]>

* Adding sentencepiece tokenizer test for export

Signed-off-by: Onur Yilmaz <[email protected]>

* More unit tests for tensorrt_llm.py

Signed-off-by: Onur Yilmaz <[email protected]>

* more tensorrt_mm_exporter tests

Signed-off-by: Onur Yilmaz <[email protected]>

* Fix style

Signed-off-by: Onur Yilmaz <[email protected]>

* Add header

Signed-off-by: Onur Yilmaz <[email protected]>

* Apply isort and black reformatting

Signed-off-by: oyilmaz-nvidia <[email protected]>

* new tests for lora and export utils

Signed-off-by: Onur Yilmaz <[email protected]>

* Apply isort and black reformatting

Signed-off-by: oyilmaz-nvidia <[email protected]>

* Fix some of the codeql issues

Signed-off-by: Onur Yilmaz <[email protected]>

* Add header

Signed-off-by: Onur Yilmaz <[email protected]>

* Marking tests as GPU only

Signed-off-by: Onur Yilmaz <[email protected]>

---------

Signed-off-by: Onur Yilmaz <[email protected]>
Signed-off-by: oyilmaz-nvidia <[email protected]>
Co-authored-by: oyilmaz-nvidia <[email protected]>
Co-authored-by: oliver könig <[email protected]>
Signed-off-by: Charlie Truong <[email protected]>
chtruong814 pushed a commit that referenced this pull request May 9, 2025
* Tests for vLLMHFExporter and TensorRT lazy compiler



* Adding sentencepiece tokenizer test for export



* More unit tests for tensorrt_llm.py



* more tensorrt_mm_exporter tests



* Fix style



* Add header



* Apply isort and black reformatting



* new tests for lora and export utils



* Apply isort and black reformatting



* Fix some of the codeql issues



* Add header



* Marking tests as GPU only



---------

Signed-off-by: Onur Yilmaz <[email protected]>
Signed-off-by: oyilmaz-nvidia <[email protected]>
Co-authored-by: Onur Yilmaz <[email protected]>
Co-authored-by: oyilmaz-nvidia <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
r2.3.0 Pick this label for auto-cherrypicking into v2.3.0 Run CICD
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants