-
Notifications
You must be signed in to change notification settings - Fork 2.9k
use null tokenizer #13480
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use null tokenizer #13480
Conversation
Signed-off-by: Malay Nagda <[email protected]>
Signed-off-by: malay-nagda <[email protected]>
Signed-off-by: Malay Nagda <[email protected]>
Signed-off-by: Malay Nagda <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
[🤖]: Hi @malay-nagda 👋, We wanted to let you know that a CICD pipeline for this PR just finished successfully. So it might be time to merge this PR or get some approvals. Due to a major CI change, merges are currently handled by the automation team. |
CI is ready, let us know when to merge |
Signed-off-by: Malay Nagda <[email protected]>
Signed-off-by: Malay Nagda <[email protected]>
Signed-off-by: malay-nagda <[email protected]>
[🤖]: Hi @malay-nagda 👋, We wanted to let you know that a CICD pipeline for this PR just finished successfully. So it might be time to merge this PR or get some approvals. |
Important
The
Update branch
button must only be pressed in very rare occassions.An outdated branch is never blocking the merge of a PR.
Please reach out to the automation team before pressing that button.
What does this PR do ?
Tokenizer defaults to NullTokenizer. Provides option to use HuggingFace Tokenizer.
Collection: [llm]
Changelog
Usage
Use
--use_hf_tokenizer
CLI argument to use HuggingFace tokenizer instead of default NullTokenizer.NOTE: HuggingFace Tokenizer will be downloaded if used and the following will be required-
"TRANSFORMERS_OFFLINE": "0"
env var inExecutor.env_vars
GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
Before your PR is "Ready for review"
Pre checks:
PR Type:
If you haven't finished some of the above items you can still open "Draft" PR.
Who can review?
Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.
Additional Information