Skip to content

Incorporate 25.04 NeMo Patches #13488

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 12 commits into from
Closed

Incorporate 25.04 NeMo Patches #13488

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
7b1496a
apply latest GSW patch from nemotron/llama
May 7, 2025
44355a6
Merge remote-tracking branch 'upstream/llmb-nemo' into nemotron-patch
May 7, 2025
27ff445
Apply isort and black reformatting
bdubauski May 7, 2025
9816c36
remove cpu pinning option
May 7, 2025
1249440
remove gpu metrics option
May 7, 2025
206069f
Merge branch 'nemotron-patch' of github.com:bdubauski/llmb-nemo into …
May 7, 2025
ebca679
Apply isort and black reformatting
bdubauski May 7, 2025
0d6cd37
remove pinning, use NEMORUN_HOME
May 7, 2025
ecfa211
Merge branch 'nemotron-patch' of github.com:bdubauski/llmb-nemo into …
May 7, 2025
7c3ae4a
process extra nsys arguments
May 7, 2025
a80bd4c
switch checkpoint control to CLI args
May 8, 2025
1c7dc63
Apply isort and black reformatting
bdubauski May 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Apply isort and black reformatting 
Signed-off-by: bdubauski <[email protected]>
  • Loading branch information
@bdubauski
bdubauski committed May 7, 2025
commit ebca6795c19669035a8e9911fffce2160512f940
8 changes: 7 additions & 1 deletion scripts/performance/llm/pretrain_nemotron4_15b.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,7 +177,13 @@ def override_recipe_configs(
]

if args.enable_nsys:
plugins.append(NsysPlugin(start_step=args.profiling_start_step, end_step=args.profiling_stop_step, ranks=list(range(num_nodes * args.gpus_per_node))))
plugins.append(
NsysPlugin(
start_step=args.profiling_start_step,
end_step=args.profiling_stop_step,
ranks=list(range(num_nodes * args.gpus_per_node)),
)
)

with run.Experiment(exp_name) as exp:
exp.add(
Expand Down
8 changes: 7 additions & 1 deletion scripts/performance/llm/pretrain_nemotron4_340b.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -200,7 +200,13 @@ def override_recipe_configs(
]

if args.enable_nsys:
plugins.append(NsysPlugin(start_step=args.profiling_start_step, end_step=args.profiling_stop_step, ranks=list(range(num_nodes * args.gpus_per_node))))
plugins.append(
NsysPlugin(
start_step=args.profiling_start_step,
end_step=args.profiling_stop_step,
ranks=list(range(num_nodes * args.gpus_per_node)),
)
)

with run.Experiment(exp_name) as exp:
exp.add(
Expand Down