-
Notifications
You must be signed in to change notification settings - Fork 379
Add Stochastic flow matching for corrdiff #836
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
daviddpruitt
wants to merge
25
commits into
NVIDIA:main
Choose a base branch
from
daviddpruitt:sfm
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
25 commits
Select commit
Hold shift + click to select a range
3caf586
Adding modules and initial pass of example code
daviddpruitt 9b056ee
add configs, update training script for sfm
daviddpruitt 71e8964
update configs
daviddpruitt a065c74
update imports, formatting
daviddpruitt 51f789c
fix comment formatting
daviddpruitt 4f57f6f
add missing encoder
daviddpruitt 6bc84c5
update configs and imports
daviddpruitt d6f148d
add missing denoiser ema and ddp
daviddpruitt e6f3398
various bugfixes
daviddpruitt 5ea8900
fix missing attributes
daviddpruitt 409b011
update generation scripts
daviddpruitt b093b08
various fixes for generation
daviddpruitt f539e99
update to physicsnemo
daviddpruitt 5241da0
fixes for sfm_encoder and sfm_two_stage
daviddpruitt 89ab0e0
Linting and format fixes
daviddpruitt 5e649a7
add sfm loss tests
daviddpruitt d153ea6
Add tests
daviddpruitt 300a88c
add tests for sfm
daviddpruitt 1b921e4
fix for change in loss interface
daviddpruitt e306842
rename to cordiff plus plus
daviddpruitt 2d75783
add readme
daviddpruitt 96492d9
Merge branch 'NVIDIA:main' into sfm
daviddpruitt 5d4c7e3
Update train.py
daviddpruitt 302fb98
Update train.py
daviddpruitt 67d3e54
Update README.md
daviddpruitt File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
fix comment formatting
- Loading branch information
commit 51f789c3d6b57771da590263090680591084f62a
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My high-level comment on this is that functionally
SFMPrecondSR
has the same behavior asEDMPrecondSR
(aside from the extraget_sigma_max
andupdate_sigma_max
methods). At least as far as I can tell, correct me if I'm wrong.Can you possibly refactor so that
EDMPrecondSR
can be used instead? The reason is we are currently suffering from a growing number of near-identical copies of EDM utilities (from CorrDiff variants and other projects), which is becoming hard to maintain and increasingly confusing for users/developers. It seems like here we can simply add the extra methods (which are simple) to theEDMPrecondSR
along with some config/arg checking in__init__
to ensure proper usage, and we avoid having an extra module with extra CI tests, etc. @CharlelieLrt for viz