Fixes for test collection and guards for missing PhysicsNeMo-Sym #902
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PhysicsNeMo Pull Request
Description
Addresses two bugs:
pytest .
from root caused an error in test collection due to path issues intest_runner.py
. Fixed this, and refactored to use the more-modernpathlib
builtin library instead ofos.path
. (In general, going forward, we should typically preferpathlib
overos.path
)This provides a fix for the first bug, and at least a more graceful failure for the second bug.
Checklist
Dependencies