-
Notifications
You must be signed in to change notification settings - Fork 257
Fix time blackrock #1708
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix time blackrock #1708
Conversation
@zm711 @h-mayorquin found this other error, small but important. We were getting the wrong start recording time (in the miliseconds scale) |
…ython-neo into fix-time-blackrock
@luiztauffer could you post an image just of the times before and after? Since I don't know the format it is hard for me to know when to do the factor of 1000 or not? Or a link to some documentation :) |
The corresponding description of the NEV header: Here is the spec for the timestamps where you can see that the last two bytes are milliseconds as per the windows convention and we read here: python-neo/neo/rawio/blackrockrawio.py Lines 1131 to 1161 in 5df3403
And you can see that the datetime object requieres microseconds here: https://docs.python.org/3/library/datetime.html#datetime.datetime |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool thanks I didn't realize datetime needed the microseconds. Sorry read too fast :)
a quick fix for the miliseconds / microseconds part of rec_datetime