Skip to content

Add feature to define findings manually in the model, similar to over… #180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Add feature to define findings manually in the model, similar to over… #180

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
82bc106
Add feature to define findings manually in the model, similar to over…
nozmore-vera Oct 2, 2021
9e0fce5
rename from 'custom' to 'manual' findings.
nozmore-vera Oct 5, 2021
1eaeded
Added source element to Findings, merged manual findings into main an…
nozmore-vera Oct 5, 2021
1640899
Removed duplicate element reference when assigning a manual finding t…
nozmore-vera Oct 5, 2021
389ee11
remove manual_findings attribute and re-use findings. Updated sample …
nozmore-vera Oct 5, 2021
05f6dfd
review comments. In addition to supporting Findings added to an eleme…
nozmore-vera Oct 5, 2021
34959b6
Code cleanup, removed unnecessary condition.
nozmore-vera Oct 12, 2021
f577e66
Merge branch 'master' into custom_findings
nozmore-vera Oct 31, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Code cleanup, removed unnecessary condition.
  • Loading branch information
@nozmore-vera
nozmore-vera committed Oct 12, 2021
commit 34959b68ce51d5771d1caae26a08ed6e975b8c0f
11 changes: 4 additions & 7 deletions pytm/pytm.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,15 +59,12 @@ def __set__(self, instance, value):
# called when x.d = val
# instance = x
# value = val

if instance in self.data:
if (not isinstance(instance, Finding)):
raise ValueError(
"cannot overwrite {}.{} value with {}, already set to {}".format(
instance, self.__class__.__name__, value, self.data[instance]
)
raise ValueError(
"cannot overwrite {}.{} value with {}, already set to {}".format(
instance, self.__class__.__name__, value, self.data[instance]
)

)
self.data[instance] = value
if self.onSet is not None:
self.onSet(instance, value)
Expand Down