-
Notifications
You must be signed in to change notification settings - Fork 599
NMS-18004: Add REST Endpoint for Viewing, Creating, and modifying Situations #7789
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few small nitpicks.
opennms-webapp-rest/src/main/java/org/opennms/web/rest/v2/SituationsRestService.java
Show resolved
Hide resolved
opennms-webapp-rest/src/main/java/org/opennms/web/rest/v2/SituationsRestService.java
Show resolved
Hide resolved
smoke-test/src/test/java/org/opennms/smoketest/rest/SituationRestServicesIT.java
Outdated
Show resolved
Hide resolved
opennms-webapp-rest/src/main/java/org/opennms/web/rest/v2/SituationsRestService.java
Outdated
Show resolved
Hide resolved
opennms-webapp-rest/src/main/java/org/opennms/web/rest/v2/SituationsRestService.java
Show resolved
Hide resolved
opennms-webapp-rest/src/main/java/org/opennms/web/rest/v2/SituationsRestService.java
Outdated
Show resolved
Hide resolved
opennms-webapp-rest/src/main/java/org/opennms/web/rest/v2/SituationsRestService.java
Outdated
Show resolved
Hide resolved
opennms-webapp-rest/src/main/java/org/opennms/web/rest/v2/SituationsRestService.java
Show resolved
Hide resolved
opennms-webapp-rest/src/main/java/org/opennms/web/rest/v2/SituationsRestService.java
Show resolved
Hide resolved
opennms-webapp-rest/src/main/java/org/opennms/web/rest/v2/SituationsRestService.java
Outdated
Show resolved
Hide resolved
This PR misses any documentation. You need to add something to Development -> Rest API -> Interfaces. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR misses any documentation. You need to add something to Development -> Rest API -> Interfaces.
opennms-webapp-rest/src/main/java/org/opennms/web/rest/v2/SituationsRestService.java
Show resolved
Hide resolved
opennms-webapp-rest/src/main/java/org/opennms/web/rest/v2/SituationsRestService.java
Show resolved
Hide resolved
opennms-webapp-rest/src/main/java/org/opennms/web/rest/v2/SituationsRestService.java
Show resolved
Hide resolved
Documentation successfully added |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a minor change needed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Create REST endpoint for Situations. This would help enable a more unified way for us to use them and enable users to more easily take advantage of them. This would work similar to how it does within the ALEC UI for situations with the ability to create a situation from alarms and then add alarms or resolve the situation.