Skip to content

NMS-18004: Add REST Endpoint for Viewing, Creating, and modifying Situations #7789

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jul 10, 2025

Conversation

Mohammad-Junid
Copy link
Contributor

@Mohammad-Junid Mohammad-Junid commented Jul 2, 2025

Create REST endpoint for Situations. This would help enable a more unified way for us to use them and enable users to more easily take advantage of them. This would work similar to how it does within the ALEC UI for situations with the ability to create a situation from alarms and then add alarms or resolve the situation.

@indigo423 indigo423 changed the title NMS-18004 Add REST Endpoint for Viewing, Creating, and modifying Situations NMS-18004: Add REST Endpoint for Viewing, Creating, and modifying Situations Jul 2, 2025
Copy link
Contributor

@mwajahatabbasi mwajahatabbasi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few small nitpicks.

@christianpape
Copy link
Contributor

This PR misses any documentation. You need to add something to Development -> Rest API -> Interfaces.

Copy link
Contributor

@christianpape christianpape left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR misses any documentation. You need to add something to Development -> Rest API -> Interfaces.

@github-actions github-actions bot added the docs label Jul 9, 2025
@github-actions github-actions bot requested a review from indigo423 July 9, 2025 11:23
@Mohammad-Junid
Copy link
Contributor Author

Mohammad-Junid commented Jul 9, 2025

This PR misses any documentation. You need to add something to Development -> Rest API -> Interfaces.

Documentation successfully added

Copy link
Contributor

@christianpape christianpape left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a minor change needed.

Copy link
Contributor

@christianpape christianpape left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@Mohammad-Junid Mohammad-Junid merged commit b75eb8e into develop Jul 10, 2025
6 checks passed
@Mohammad-Junid Mohammad-Junid deleted the jira/MJ/NMS-18004- branch July 10, 2025 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants