Changes for Windows OpenVox builds #10
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nmburgan
force-pushed
the
windows
branch
8 times, most recently
from
e8de987 to
14b3a89
Compare
These changes allow us to build puppet-runtime for windows-2019-x64 (really, any Windows flavor, but we'll use this platform string for now). The builder image is simply any version of current-ish Windows (I used Windows Server 2022 and Windows 11 for testing these changes). To prep the image: Put the Cygwin installer at C:\setup-x86_64.EXE At the base of this repo, run setup.bat. This also bumps Boost to 1.82.0 for Windows. This was necessary in order to fix a bug in building on Windows with Cygwin. boostorg/locale@41868c6 However, I still don't have pxp-agent building correctly for Windows. Likely we will just build it without for now. But leaving the changes in here in case we need them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes allow us to build puppet-runtime for windows-2019-x64 (really, any Windows flavor, but we'll use this platform string for now). The builder image is simply any version of current-ish Windows (I used Windows Server 2022 and Windows 11 for testing these changes).
To prep the image:
Put the Cygwin installer at C:\setup-x86_64.EXE
At the base of this repo, run setup.bat.
This also bumps Boost to 1.82.0 for Windows only. This was necessary in order to fix a bug in building on Windows with Cygwin. boostorg/locale@41868c6
However, I still don't have pxp-agent building correctly for Windows. Likely we will just build it without for now. But leaving the changes in here in case we need them.