ERC7821WithExecutor instead of VestingWalletExecutorConfidential
#104
+391
−156
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… github.com:OpenZeppelin/openzeppelin-confidential-contracts into feature/batch-fund-vesting-wallets-executor-erc7821
Amxx
reviewed
Jul 11, 2025
Amxx
reviewed
Jul 11, 2025
arr00
merged commit 70d754f
into
james/feature/batch-fund-vesting-wallets-executor
9 checks passed
arr00
added a commit
that referenced
this pull request
Jul 11, 2025
* Fund multiple `VestingWalletConfidential` in batch * Deploy full vesting wallets from factory * Increase pragma in factory * fix types in `_vestingSchedule` * Update changeset Co-authored-by: Arr00 <[email protected]> * Add more context to events * Update doc & comments * Format doc * Check cliff in batcher * Remove total transfered amount computation in batcher * Set factory as non abstract * Lighten vesting struct & check beneficiary from batcher * up * `ERC7821WithExecutor` instead of `VestingWalletExecutorConfidential` (#104) * Init executor with ERC7821 * Update `ERC7821WithExecutor` * rename executor file * update tests * move `ERC7821WithExecutor` test * fix tests * update test * use vanilla helpers * disable slither for locking ether --------- Co-authored-by: James Toussaint <[email protected]> Co-authored-by: Hadrien Croubois <[email protected]> * clean * fix imports order * Apply suggestions from code review * up * update comments * remove constructor * fix function ordering * add changeset * Update .changeset/tricky-boxes-train.md Co-authored-by: Ernesto García <[email protected]> * `VestingWalletConfidentialFactory` -> `VestingWalletCliffExecutorConfidentialFactory` * Duration and Cliff per vesting plan (#105) * Update .changeset/poor-colts-glow.md * upgrade pragmas * fix docs --------- Co-authored-by: James Toussaint <[email protected]> Co-authored-by: Hadrien Croubois <[email protected]> Co-authored-by: Ernesto García <[email protected]>
arr00
added a commit
that referenced
this pull request
Jul 11, 2025
* Fund multiple `VestingWalletConfidential` in batch * Deploy full vesting wallets from factory * Increase pragma in factory * fix types in `_vestingSchedule` * Update changeset Co-authored-by: Arr00 <[email protected]> * Add more context to events * Update doc & comments * Format doc * Check cliff in batcher * Remove total transfered amount computation in batcher * Set factory as non abstract * Lighten vesting struct & check beneficiary from batcher * up * `ERC7821WithExecutor` instead of `VestingWalletExecutorConfidential` (#104) * Init executor with ERC7821 * Update `ERC7821WithExecutor` * rename executor file * update tests * move `ERC7821WithExecutor` test * fix tests * update test * use vanilla helpers * disable slither for locking ether --------- Co-authored-by: James Toussaint <[email protected]> Co-authored-by: Hadrien Croubois <[email protected]> * clean * fix imports order * Apply suggestions from code review * up * update comments * remove constructor * fix function ordering * add changeset * Update .changeset/tricky-boxes-train.md Co-authored-by: Ernesto García <[email protected]> * `VestingWalletConfidentialFactory` -> `VestingWalletCliffExecutorConfidentialFactory` * Duration and Cliff per vesting plan (#105) * Update .changeset/poor-colts-glow.md * upgrade pragmas * fix docs --------- Co-authored-by: James Toussaint <[email protected]> Co-authored-by: Hadrien Croubois <[email protected]> Co-authored-by: Ernesto García <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.