add initializable version of vesting #95
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ernestognw
reviewed
Jul 8, 2025
ernestognw
reviewed
Jul 8, 2025
| contract Create2Factory { | ||
| event Deployed(address clone); | ||
|
|
||
| function create2(address impl, bytes memory data) public returns (address) { |
There was a problem hiding this comment.
Is it a concern that clone creation can be frontrunned? Subsequent creations would fail, I wonder if in the context of Zama's use case it would makes sense to ensure create2 is idempotent
arr00
added a commit
that referenced
this pull request
Jul 9, 2025
* add initializable version of vesting * update tests
arr00
added a commit
that referenced
this pull request
Jul 9, 2025
* add initializable version of vesting * update tests
arr00
added a commit
that referenced
this pull request
Jul 10, 2025
* Add Vesting Wallet * fix and add tests * remove unused imports * fix test * add operator * fix test * add changeset * make vesting wallets cloneable * Apply suggestions from code review Co-authored-by: James Toussaint <[email protected]> * add call event * add initializable version of vesting (#95) * add initializable version of vesting * update tests * remove factory mock * rename mock files * fix imports * remove upgradeable dependency * add docs * revert `package-lock.json` changes * fix import paths * fix lint * Update contracts/finance/VestingWalletConfidential.sol Co-authored-by: Hadrien Croubois <[email protected]> * fix tests * add reentrancy protection * extract executor into extension * forge install: openzeppelin-contracts-upgradeable v5.3.0 * update package * fix overflow risk * Add vesting wallet namespace storage (#96) * Add vesting wallet namespace storage * update pragmas * reorder functions * fix lint and inline getting storage --------- Co-authored-by: Arr00 <[email protected]> * update docs * update cliff seconds param size * remove upgradeable file * add docs * Update .changeset/cold-nails-go.md Co-authored-by: James Toussaint <[email protected]> * update comments --------- Co-authored-by: James Toussaint <[email protected]> Co-authored-by: Hadrien Croubois <[email protected]>
arr00
added a commit
that referenced
this pull request
Jul 10, 2025
* Add Vesting Wallet * fix and add tests * remove unused imports * fix test * add operator * fix test * add changeset * make vesting wallets cloneable * Apply suggestions from code review Co-authored-by: James Toussaint <[email protected]> * add call event * add initializable version of vesting (#95) * add initializable version of vesting * update tests * remove factory mock * rename mock files * fix imports * remove upgradeable dependency * add docs * revert `package-lock.json` changes * fix import paths * fix lint * Update contracts/finance/VestingWalletConfidential.sol Co-authored-by: Hadrien Croubois <[email protected]> * fix tests * add reentrancy protection * extract executor into extension * forge install: openzeppelin-contracts-upgradeable v5.3.0 * update package * fix overflow risk * Add vesting wallet namespace storage (#96) * Add vesting wallet namespace storage * update pragmas * reorder functions * fix lint and inline getting storage --------- Co-authored-by: Arr00 <[email protected]> * update docs * update cliff seconds param size * remove upgradeable file * add docs * Update .changeset/cold-nails-go.md Co-authored-by: James Toussaint <[email protected]> * update comments --------- Co-authored-by: James Toussaint <[email protected]> Co-authored-by: Hadrien Croubois <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.