Skip to content

Refine setup.py #10577

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 15, 2025
Merged

Refine setup.py #10577

merged 3 commits into from
May 15, 2025

Conversation

risemeup1
Copy link
Contributor

@risemeup1 risemeup1 commented May 9, 2025 •
edited
Loading

Before submitting

  • Lint code. If there are lint issues, please format the code first.
# Install and register `pre-commit` in the project folder
pip install pre-commit && pre-commit install

# Process previous code files separately
pre-commit run --file XXXX.py
  • Add test cases into tests folder. If there are codecov issues, please add tests cases first.

PR types

PR changes

Description

把fp8相关的自定义算子分出来，避免和原来的算子冲突，便于管理

@paddle-bot Paddle-bot
Copy link

paddle-bot bot commented May 9, 2025

Thanks for your contribution!

@risemeup1 risemeup1 changed the base branch from develop to dsv3_dev May 9, 2025 14:29
@risemeup1 risemeup1 changed the title Fix setup.py Refine setup.py May 15, 2025
@risemeup1 risemeup1 force-pushed the fix_setup.py branch 2 times, most recently from cb49846 to ca14156 Compare May 15, 2025 06:49
A-nnonymous
A-nnonymous approved these changes May 15, 2025
View reviewed changes
Copy link

@A-nnonymous A-nnonymous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

slm/model_zoo/gpt-3/external_ops/setup.py Outdated
from paddle.device import is_compiled_with_rocm
from paddle.utils.cpp_extension import CUDAExtension, setup
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

尽量不要动其他东西，这个文件只做删除，避免解释成本

@phlrain phlrain merged commit 670cbd9 into PaddlePaddle:dsv3_dev May 15, 2025
2 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@A-nnonymous A-nnonymous A-nnonymous approved these changes

@zhangbo9674 zhangbo9674 zhangbo9674 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@risemeup1 @A-nnonymous @zhangbo9674 @phlrain