Skip to content

增加rl目录下的init.py文件 #10581

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 12, 2025
Merged

增加rl目录下的init.py文件 #10581

merged 2 commits into from
May 12, 2025

Conversation

SdeeRK
Copy link
Contributor

@SdeeRK SdeeRK commented May 12, 2025

Before submitting

  • Lint code. If there are lint issues, please format the code first.
# Install and register `pre-commit` in the project folder
pip install pre-commit && pre-commit install

# Process previous code files separately
pre-commit run --file XXXX.py
  • Add test cases into tests folder. If there are codecov issues, please add tests cases first.

PR types

Bug fixes

PR changes

Others

Description

The RL module lacks init.py files.
Add init.py files to RL module and submodule for proper package structure

python setup.py bdist_wheel

Copy link

paddle-bot bot commented May 12, 2025

Thanks for your contribution!

@CLAassistant
Copy link

CLAassistant commented May 12, 2025

CLA assistant check
All committers have signed the CLA.

Copy link

codecov bot commented May 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 46.98%. Comparing base (759ae99) to head (9b595b1).
Report is 4 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #10581      +/-   ##
===========================================
- Coverage    48.66%   46.98%   -1.69%     
===========================================
  Files          768      799      +31     
  Lines       127103   132246    +5143     
===========================================
+ Hits         61860    62136     +276     
- Misses       65243    70110    +4867     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@SdeeRK
Copy link
Contributor Author

SdeeRK commented May 12, 2025

PR types

feat: Add init.py files to RL module and submodule for proper package structure

PR changes

  • paddlenlp/rl/__init__.py
  • paddlenlp/rl/submodule/__init__.py

Description

The RL module lacks __init__.py files

@JunnYu JunnYu self-requested a review May 12, 2025 09:43
Copy link
Member

@JunnYu JunnYu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gongel gongel merged commit 3570aaa into PaddlePaddle:develop May 12, 2025
9 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants