Skip to content

[RL] Add reshard controller #10606

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 19, 2025
Merged

[RL] Add reshard controller #10606

merged 1 commit into from
May 19, 2025

Conversation

fjjF77
Copy link
Contributor

@fjjF77 fjjF77 commented May 16, 2025

PR types

Bug fixes

PR changes

APIs

Description

添加reshard controller控制训练推理时分片设置切换。

Copy link

paddle-bot bot commented May 16, 2025

Thanks for your contribution!

@fjjF77 fjjF77 marked this pull request as ready for review May 16, 2025 10:52
@gongel gongel mentioned this pull request May 17, 2025
2 tasks
@gongel gongel changed the title update reshard [RL] Update reshard May 17, 2025
@gongel gongel assigned gongel and unassigned KB-Ding May 17, 2025
Copy link

codecov bot commented May 18, 2025

Codecov Report

Attention: Patch coverage is 0% with 114 lines in your changes missing coverage. Please review.

Project coverage is 46.94%. Comparing base (ddcb722) to head (a7f938f).
Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
paddlenlp/rl/utils/reshard_utils.py 0.00% 57 Missing ⚠️
paddlenlp/rl/utils/infer_utils.py 0.00% 27 Missing ⚠️
paddlenlp/rl/trainer/rl_trainer.py 0.00% 11 Missing ⚠️
paddlenlp/rl/utils/comm_utils.py 0.00% 11 Missing ⚠️
paddlenlp/rl/trainer/ppo_trainer.py 0.00% 8 Missing ⚠️

❌ Your patch status has failed because the patch coverage (0.00%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.
❌ Your project status has failed because the head coverage (46.94%) is below the target coverage (58.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #10606      +/-   ##
===========================================
- Coverage    46.94%   46.94%   -0.01%     
===========================================
  Files          799      799              
  Lines       132348   132364      +16     
===========================================
- Hits         62137    62136       -1     
- Misses       70211    70228      +17     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@fjjF77 fjjF77 changed the title [RL] Update reshard [RL] Add reshard controller May 19, 2025
@gongel gongel merged commit c654d1a into PaddlePaddle:develop May 19, 2025
8 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants