Skip to content

[LLM] fix sharding v1 reshard #10610

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

SylarTiaNII
Copy link
Contributor

PR types

Bug fixes

PR changes

Others

Description

fix sharding reshard

Copy link

paddle-bot bot commented May 18, 2025

Thanks for your contribution!

Copy link

codecov bot commented May 19, 2025

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 48.87%. Comparing base (4213c30) to head (aba16b6).
Report is 6 commits behind head on incubate/paddlenlp-fleety_20250421.

Files with missing lines Patch % Lines
paddlenlp/trainer/utils/reshard/sharding_v1.py 0.00% 1 Missing ⚠️

❌ Your patch status has failed because the patch coverage (0.00%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.
❌ Your project status has failed because the head coverage (48.87%) is below the target coverage (58.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files
@@                          Coverage Diff                           @@
##           incubate/paddlenlp-fleety_20250421   #10610      +/-   ##
======================================================================
- Coverage                               48.89%   48.87%   -0.02%     
======================================================================
  Files                                     768      769       +1     
  Lines                                  126453   126496      +43     
======================================================================
  Hits                                    61825    61825              
- Misses                                  64628    64671      +43     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Collaborator

@DrownFish19 DrownFish19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DrownFish19 DrownFish19 merged commit ef68026 into PaddlePaddle:incubate/paddlenlp-fleety_20250421 May 19, 2025
5 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants