Skip to content

[Minor] Optimize codestyle #1740

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 90 commits into
base: develop
Choose a base branch
from

Conversation

Coronia
Copy link
Contributor

@Coronia Coronia commented Jun 27, 2025

Split from #1535. Despite editing many files, it only contains 2 change mostly:

  • added const to variables that's not supposed to be changed, so the compiler might optimize it during building the dll
  • cached some variables that would be used multiple time to reduce pointer call

Coronia and others added 30 commits March 15, 2024 19:28
+misc codestyle fixes
- Fix a regression in AE cloak code
- Fix DecloakToFire=no not preventing decloaking when having a target in range
- Move cloak-related code to its own file
Coronia added 8 commits June 15, 2025 19:40
# Conflicts:
#	src/Ext/Bullet/Hooks.DetonateLogics.cpp
#	src/Ext/Rules/Body.cpp
#	src/Ext/Rules/Body.h
#	src/Ext/TAction/Body.cpp
#	src/Ext/Techno/Body.Internal.cpp
#	src/Ext/Techno/Body.Update.cpp
#	src/Ext/Techno/Body.cpp
#	src/Misc/Hooks.BugFixes.cpp
#	src/New/Entity/AttachEffectClass.cpp
#	src/New/Entity/ShieldClass.cpp
# Conflicts:
#	src/Commands/NextIdleHarvester.cpp
#	src/Ext/Anim/Hooks.cpp
#	src/Ext/Building/Hooks.Grinding.cpp
#	src/Ext/CaptureManager/Body.cpp
#	src/Ext/Script/Mission.Move.cpp
#	src/Ext/Techno/Hooks.Pips.cpp
#	src/Ext/Techno/Hooks.Transport.cpp
#	src/Ext/Techno/Hooks.cpp
#	src/Misc/Hooks.BugFixes.cpp
#	src/New/Entity/ShieldClass.cpp
# Conflicts:
#	src/Ext/EBolt/Hooks.cpp
#	src/Ext/House/Hooks.cpp
#	src/New/Entity/AttachEffectClass.cpp
# Conflicts:
#	src/Ext/Bullet/Hooks.DetonateLogics.cpp
@github-actions github-actions bot added the Minor Documentation is not required label Jun 27, 2025
Copy link

github-actions bot commented Jun 27, 2025

Nightly build for this pull request:

This comment is automatic and is meant to allow guests to get latest nightly builds for this pull request without registering. It is updated on every successful build.

@Starkku Starkku force-pushed the develop branch 2 times, most recently from b429215 to 280b1c8 Compare June 29, 2025 19:13
# Conflicts:
#	src/Ext/Building/Hooks.Grinding.cpp
#	src/Ext/Script/Body.cpp
#	src/Ext/Techno/Hooks.ReceiveDamage.cpp
#	src/Misc/Hooks.BugFixes.cpp
#	src/New/Entity/AttachEffectClass.cpp
@Coronia Coronia added Tested ⚙️T1 T1 maintainer review is sufficient labels Jul 5, 2025
Coronia added 2 commits July 6, 2025 19:21
# Conflicts:
#	src/Ext/Bullet/Body.cpp
#	src/Ext/Techno/Body.Update.cpp
#	src/Ext/Techno/Hooks.ReceiveDamage.cpp
#	src/Ext/WarheadType/Body.cpp
#	src/Ext/WarheadType/Detonate.cpp
@Coronia Coronia force-pushed the small-fix-3 branch 3 times, most recently from 3b63ff1 to d18a3dd Compare July 7, 2025 13:30
@Coronia Coronia force-pushed the small-fix-3 branch 2 times, most recently from 5904aae to 928025b Compare July 8, 2025 03:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Minor Documentation is not required ⚙️T1 T1 maintainer review is sufficient Tested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants