Skip to content

[Minor] Fix to InfantryType #1757

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 18 commits into
base: develop
Choose a base branch
from

Conversation

a851903106
Copy link
Contributor

@a851903106 a851903106 commented Jul 9, 2025

Engineers can enter buildings normally when they don't need to be repaired (or you can force it by pressing Alt).
建筑不需要修理时,工程师可以正常进入建筑(也可以按 Alt 键强制进入)。

Player-controlled spies are not forced to perform other tasks while attacking buildings
玩家控制的间谍在攻击建筑时不会被迫执行其他任务。

Infantry in deployed state will not trigger RateUp on Gatling.
部署状态的步兵不会触发盖特逻辑的RateUp

MultiWeapon=yes or IsGattling=yes allows infantry to select weapons normally when they are no longer in the deployed state.
MultiWeapon=yesIsGattling=yes允许步兵在不处于部署状态时正常选择武器。

If BombDisarm=Yes is not present for all weapon warheads, then the engineer will no longer use the appropriate mouse action.
如果所有武器弹头都不存在BombDisarm=Yes,那么工程师将不再使用相应的鼠标动作。

工程师修复

@github-actions github-actions bot added the Minor Documentation is not required label Jul 9, 2025
Copy link

github-actions bot commented Jul 9, 2025

Nightly build for this pull request:

This comment is automatic and is meant to allow guests to get latest nightly builds for this pull request without registering. It is updated on every successful build.

@a851903106 a851903106 changed the title [Minor] Minor fix to InfantryType [Minor] Fix to InfantryType Jul 9, 2025
@Coronia Coronia requested a review from CrimRecya July 9, 2025 10:13
Copy link
Contributor

@CrimRecya CrimRecya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When executing waypoint commands, you need to ignore the keys the player has pressed. You can see this processing at the beginning of the MouseOverObject.
Additionally, I suggest giving the return addresses some easily understandable names, which would be clearer.

@TaranDahl
Copy link
Contributor

more comments plz :P

@a851903106
Copy link
Contributor Author

When executing waypoint commands, you need to ignore the keys the player has pressed. You can see this processing at the beginning of the MouseOverObject. Additionally, I suggest giving the return addresses some easily understandable names, which would be clearer.

They're kind of hard to read.

@TaranDahl TaranDahl added ⚙️T1 T1 maintainer review is sufficient ❓Unhardcoding / Customization Make something more tweakable labels Jul 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Minor Documentation is not required ⚙️T1 T1 maintainer review is sufficient ❓Unhardcoding / Customization Make something more tweakable
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants