let value-pack and value-list traits use only values

Summary: GCC has trouble with references to non-type template parameters.

Differential Revision: D58636952

fbshipit-source-id: 507664de8ae1d5fa35c652f697fb055d1b4f33f7

restore rpm system deps for fedora (facebook#2231)

Summary:
[getdeps] restore rpm system deps for fedora

centOS (even stream) tends to be quite old and thus ends up having its rpm system deps turned off, e.g. boost in D55758008 and glog and gtest in D51813855.  Unfortunate the rpm deps were removed entirely rather than limited by distro or distro_vers.

Lets restore the rpm deps but specify distro=fedora to reduce the risk of people removing them entirely.

Also:
   * fedora has up to date gtest & gmock, so use them
   * zlib-ng-compat added from fedora 38 with zlib removed from F40, so update zlib rpm names.  F37 is EOL

Pull Request resolved: facebook#2231

Test Plan:
Build locally on fedora 40:
```
./build/fbcode_builder/getdeps.py install-system-deps --recursive folly
./build/fbcode_builder/getdeps.py --allow-system-packages build --src-dir=. folly
```

Reviewed By: HarveyHunt

Differential Revision: D58324546

Pulled By: ahornby

fbshipit-source-id: a4d5e8620cf55701e19317a301db3846d60f8d4b

enable more brew system deps (facebook#2219)

Summary:
Pull Request resolved: facebook#2219

Save a bit of time on each github build. Enable homebrew system deps for fmt, gflags, glog, googletest, snappy

Reviewed By: chadaustin

Differential Revision: D57967014

fbshipit-source-id: 286ba96fb384e1b5e8f4e97160af2b801e458aef

cut unused macro FOLLY_SINGLETON_TRY_GET

Summary: It is unused.

Reviewed By: dmm-fb

Differential Revision: D57815314

fbshipit-source-id: f582c248cad626f8ed3980ce26d243336d88bf46

-Wdeprecated-literal-operator fixes

Summary:
Fix deprecated literal operators:
```
./xplat/folly/FixedString.h:2923:1: error: identifier '_fs64' preceded by whitespace in a literal operator declaration is deprecated [-Werror,-Wdeprecated-literal-operator]
 2923 | FOLLY_DEFINE_FIXED_STRING_UDL(64)
      | ^
./xplat/folly/FixedString.h:2912:39: note: expanded from macro 'FOLLY_DEFINE_FIXED_STRING_UDL'
 2912 |   constexpr FixedString<N> operator"" _fs##N(                \
      |                                       ^
```

Reviewed By: drodriguez

Differential Revision: D57494889

fbshipit-source-id: 7120f44d28abdcc6b8cd4dfa86a78c6903d805ab

Support `co_return;` in coro `Expected` of empty trivial types like `…

…Unit`

Summary:
Allow `Expected<Unit, E>` coros to return void -- aka `co_return;` or reaching the `}` closing the function. To do this, I add an `expected_detail::Promise` specialization for `Value` that is both trivial and empty, and refactor the methods that can be shared with the value-returning case into `PromiseBase`.

This is an interface change for existing `Expected` coroutines -- they need to use `co_await makeUnexpected(...)` instead of `co_return makeUnexpected(...)`.

Unlike `co_return`, it's possible for `co_await` to suspend the coroutine, which is potentially slower. In D51537604, yfeldblum measured / optimized this case a bit, so this is (hopefully) now acceptable in exchange for improved readability.

Reviewed By: yfeldblum

Differential Revision: D49253265

fbshipit-source-id: a18b407fa023fed22ef86a18116da2bacd93f30a

Deshim jemalloc in folly

Summary:
The following rules were deshimmed:
```
//folly/experimental:jemalloc_nodump_allocator -> //folly/memory:jemalloc_nodump_allocator
//folly/experimental:jemalloc_huge_page_allocator -> //folly/memory:jemalloc_huge_page_allocator
```

The following headers were deshimmed:
```
folly/experimental/JemallocNodumpAllocator.h -> folly/memory/JemallocNodumpAllocator.h
folly/experimental/JemallocHugePageAllocator.h -> folly/memory/JemallocHugePageAllocator.h
```

This is a codemod. It was automatically generated and will be landed once it is approved and tests are passing in sandcastle.
You have been added as a reviewer by Sentinel or Butterfly.

Reviewed By: yfeldblum

Differential Revision: D56308346

fbshipit-source-id: 0c03dc304d8c6ae76675d4dce95b5f75f1b34e4e

change python3 to fbpython

Summary:
there is a bunch of scripts that uses python3 to run, this means that they are at the mercy of whoever controll their path, in linux, this can be system python3, but can also be platform python (and probably it is both), and in windows in particular it abuses c:\tools\fb-python\python3.exe. fbpython is the universal way to run python at the company that chooses the right platform python, but also provides monitoring and observability.

this scripts generates jobs like

https://www.internalfb.com/sandcastle/job/18014399781484898/

that will stop working once we remove c:\tools\fb-python\python3*.exe

Reviewed By: fried

Differential Revision: D56896564

fbshipit-source-id: d911fdaf6750635adb05b096f0522603baf47bcc

Re-sync with internal repository (facebook#2180)

The internal and external repositories are out of sync. This Pull Request attempts to brings them back in sync by patching the GitHub repository. Please carefully review this patch. You must disable ShipIt for your project in order to merge this pull request. DO NOT IMPORT this pull request. Instead, merge it directly on GitHub using the MERGE BUTTON. Re-enable ShipIt after merging.

Co-authored-by: Facebook Community Bot <[email protected]>

let makeConversionError always check the ConversionCode

Summary: Just an extra check. Could potentially help disprove one plausible cause of a crash.

Differential Revision: D56368867

fbshipit-source-id: 8d641862e271f22c64f7f747064ef9327bc97db1