-
Notifications
You must be signed in to change notification settings - Fork 5.3k
Krispcall - use prod baseUrl #16639
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Krispcall - use prod baseUrl #16639
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ |
WalkthroughThis update switches the Krispcall app's API base URL from a development endpoint to the production endpoint and increments version numbers across several action and source modules. No other logic, control flow, or functional changes are introduced. Changes
Assessment against linked issues
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 ESLint
components/krispcall/actions/add-contact/add-contact.mjsOops! Something went wrong! :( ESLint: 8.57.1 Error [ERR_MODULE_NOT_FOUND]: Cannot find package 'jsonc-eslint-parser' imported from /eslint.config.mjs components/krispcall/actions/delete-contact/delete-contact.mjsOops! Something went wrong! :( ESLint: 8.57.1 Error [ERR_MODULE_NOT_FOUND]: Cannot find package 'jsonc-eslint-parser' imported from /eslint.config.mjs components/krispcall/actions/new-sms/new-sms.mjsOops! Something went wrong! :( ESLint: 8.57.1 Error [ERR_MODULE_NOT_FOUND]: Cannot find package 'jsonc-eslint-parser' imported from /eslint.config.mjs
Tip ⚡️ Faster reviews with caching
Enjoy the performance boost—your workflow just got faster. ✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
components/krispcall/krispcall.app.mjs (1)
78-82
: Cleanup and externalize base URL configuration.
Switching the default base URL to production is correct. To avoid manual toggling and commented code, consider removing the commented-out development URL and externalizing both URLs (e.g., via environment variables or config props).
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
pnpm-lock.yaml
is excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (10)
components/krispcall/actions/add-contact/add-contact.mjs
(1 hunks)components/krispcall/actions/delete-contact/delete-contact.mjs
(1 hunks)components/krispcall/actions/new-mms/new-mms.mjs
(1 hunks)components/krispcall/actions/new-sms/new-sms.mjs
(1 hunks)components/krispcall/krispcall.app.mjs
(1 hunks)components/krispcall/package.json
(1 hunks)components/krispcall/sources/new-call-instant/new-call-instant.mjs
(1 hunks)components/krispcall/sources/new-contact-instant/new-contact-instant.mjs
(1 hunks)components/krispcall/sources/new-sms-or-mms-instant/new-sms-or-mms-instant.mjs
(1 hunks)components/krispcall/sources/new-voicemail-instant/new-voicemail-instant.mjs
(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (4)
- GitHub Check: pnpm publish
- GitHub Check: Verify TypeScript components
- GitHub Check: Publish TypeScript components
- GitHub Check: Lint Code Base
🔇 Additional comments (9)
components/krispcall/actions/new-mms/new-mms.mjs (1)
7-7
: Approve version increment for Send New MMS action.
The metadata version bump from “0.0.3” to “0.0.4” is consistent with the coordinated release across KrispCall actions.components/krispcall/actions/delete-contact/delete-contact.mjs (1)
8-8
: Approve version increment for Delete Contact action.
Updating the version to “0.0.4” matches the other action modules’ patch-level bump.components/krispcall/actions/new-sms/new-sms.mjs (1)
7-7
: Approve version increment for Send New SMS action.
The change from “0.0.3” to “0.0.4” is correct and aligns with the overall version sync.components/krispcall/sources/new-call-instant/new-call-instant.mjs (1)
9-9
: Approve version increment for New Call (Instant) source.
Bumping from “0.0.1” to “0.0.2” aligns with the patch-level version updates across sources and actions.components/krispcall/sources/new-contact-instant/new-contact-instant.mjs (1)
9-9
: Approve version bump to 0.0.4
The patch correctly updates the component’s version from0.0.3
→0.0.4
, keeping it in sync with the coordinated release.components/krispcall/actions/add-contact/add-contact.mjs (1)
7-7
: Approve version bump to 0.0.4
The action’s version increment aligns with corresponding updates in other KrispCall components and the package.components/krispcall/sources/new-sms-or-mms-instant/new-sms-or-mms-instant.mjs (1)
9-9
: Approve version bump to 0.0.4
This source component’s version is now consistent with the rest of the integration’s coordinated patch release.components/krispcall/package.json (1)
3-3
: Approve package version bump to 0.2.1
Updating the package’sversion
to0.2.1
correctly reflects the cumulative component releases targeting production readiness.components/krispcall/sources/new-voicemail-instant/new-voicemail-instant.mjs (1)
9-9
: Approve version bump to 0.0.4
The voicemail source’s version increment matches the patch-level update across all KrispCall components.
Resolves #16633
Summary by CodeRabbit