Skip to content

Krispcall - use prod baseUrl #16639

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 13, 2025
Merged

Krispcall - use prod baseUrl #16639

merged 2 commits into from
May 13, 2025

Conversation

michelle0927
Copy link
Collaborator

@michelle0927 michelle0927 commented May 12, 2025

Resolves #16633

Summary by CodeRabbit

  • Chores
    • Updated version numbers for multiple actions and sources to ensure consistency.
    • Changed API requests to use the production environment instead of the development environment.
    • Incremented the overall package version.

Copy link

vercel bot commented May 12, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Ignored (Inspect) May 12, 2025 4:37pm
pipedream-docs ⬜️ Ignored (Inspect) May 12, 2025 4:37pm
pipedream-docs-redirect-do-not-edit ⬜️ Ignored (Inspect) May 12, 2025 4:37pm

Copy link
Contributor

coderabbitai bot commented May 12, 2025

Walkthrough

This update switches the Krispcall app's API base URL from a development endpoint to the production endpoint and increments version numbers across several action and source modules. No other logic, control flow, or functional changes are introduced.

Changes

Files / File Group Change Summary
components/krispcall/krispcall.app.mjs Changed the _baseUrl method to return the production API URL.
components/krispcall/actions/add-contact/add-contact.mjs Updated version from "0.0.3" to "0.0.4".
components/krispcall/actions/delete-contact/delete-contact.mjs Updated version from "0.0.3" to "0.0.4".
components/krispcall/actions/new-mms/new-mms.mjs Updated version from "0.0.3" to "0.0.4".
components/krispcall/actions/new-sms/new-sms.mjs Updated version from "0.0.3" to "0.0.4".
components/krispcall/sources/new-call-instant/new-call-instant.mjs Updated version from "0.0.1" to "0.0.2".
components/krispcall/sources/new-contact-instant/new-contact-instant.mjs Updated version from "0.0.3" to "0.0.4".
components/krispcall/sources/new-sms-or-mms-instant/new-sms-or-mms-instant.mjs Updated version from "0.0.3" to "0.0.4".
components/krispcall/sources/new-voicemail-instant/new-voicemail-instant.mjs Updated version from "0.0.3" to "0.0.4".
components/krispcall/package.json Updated package version from "0.2.0" to "0.2.1".

Assessment against linked issues

Objective Addressed Explanation
Change API base URL from development to production domain (Issue #16633)

Possibly related PRs

  • Krispcall New Call Trigger #16166: Also updates version numbers in Krispcall modules and modifies the _baseUrl logic, indicating related maintenance on the same components.

Suggested labels

User submitted

Suggested reviewers

  • luancazarine

Poem

In the meadow of code, a hop and a leap,
The Krispcall bunny wakes from sleep.
With URLs swapped from dev to live,
And version bumps to help us thrive.
Now all is fresh, production-bound—
The happiest updates ever found!
🐇✨

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

components/krispcall/actions/add-contact/add-contact.mjs

Oops! Something went wrong! :(

ESLint: 8.57.1

Error [ERR_MODULE_NOT_FOUND]: Cannot find package 'jsonc-eslint-parser' imported from /eslint.config.mjs
at packageResolve (node:internal/modules/esm/resolve:839:9)
at moduleResolve (node:internal/modules/esm/resolve:908:18)
at defaultResolve (node:internal/modules/esm/resolve:1038:11)
at ModuleLoader.defaultResolve (node:internal/modules/esm/loader:557:12)
at ModuleLoader.resolve (node:internal/modules/esm/loader:525:25)
at ModuleLoader.getModuleJob (node:internal/modules/esm/loader:246:38)
at ModuleJob._link (node:internal/modules/esm/module_job:126:49)

components/krispcall/actions/delete-contact/delete-contact.mjs

Oops! Something went wrong! :(

ESLint: 8.57.1

Error [ERR_MODULE_NOT_FOUND]: Cannot find package 'jsonc-eslint-parser' imported from /eslint.config.mjs
at packageResolve (node:internal/modules/esm/resolve:839:9)
at moduleResolve (node:internal/modules/esm/resolve:908:18)
at defaultResolve (node:internal/modules/esm/resolve:1038:11)
at ModuleLoader.defaultResolve (node:internal/modules/esm/loader:557:12)
at ModuleLoader.resolve (node:internal/modules/esm/loader:525:25)
at ModuleLoader.getModuleJob (node:internal/modules/esm/loader:246:38)
at ModuleJob._link (node:internal/modules/esm/module_job:126:49)

components/krispcall/actions/new-sms/new-sms.mjs

Oops! Something went wrong! :(

ESLint: 8.57.1

Error [ERR_MODULE_NOT_FOUND]: Cannot find package 'jsonc-eslint-parser' imported from /eslint.config.mjs
at packageResolve (node:internal/modules/esm/resolve:839:9)
at moduleResolve (node:internal/modules/esm/resolve:908:18)
at defaultResolve (node:internal/modules/esm/resolve:1038:11)
at ModuleLoader.defaultResolve (node:internal/modules/esm/loader:557:12)
at ModuleLoader.resolve (node:internal/modules/esm/loader:525:25)
at ModuleLoader.getModuleJob (node:internal/modules/esm/loader:246:38)
at ModuleJob._link (node:internal/modules/esm/module_job:126:49)

  • 6 others

Tip

⚡️ Faster reviews with caching
  • CodeRabbit now supports caching for code and dependencies, helping speed up reviews. This means quicker feedback, reduced wait times, and a smoother review experience overall. Cached data is encrypted and stored securely. This feature will be automatically enabled for all accounts on May 16th. To opt out, configure Review - Disable Cache at either the organization or repository level. If you prefer to disable all data retention across your organization, simply turn off the Data Retention setting under your Organization Settings.

Enjoy the performance boost—your workflow just got faster.

✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
components/krispcall/krispcall.app.mjs (1)

78-82: Cleanup and externalize base URL configuration.
Switching the default base URL to production is correct. To avoid manual toggling and commented code, consider removing the commented-out development URL and externalizing both URLs (e.g., via environment variables or config props).

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between f73d09d and 30a4b03.

⛔ Files ignored due to path filters (1)
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
📒 Files selected for processing (10)
  • components/krispcall/actions/add-contact/add-contact.mjs (1 hunks)
  • components/krispcall/actions/delete-contact/delete-contact.mjs (1 hunks)
  • components/krispcall/actions/new-mms/new-mms.mjs (1 hunks)
  • components/krispcall/actions/new-sms/new-sms.mjs (1 hunks)
  • components/krispcall/krispcall.app.mjs (1 hunks)
  • components/krispcall/package.json (1 hunks)
  • components/krispcall/sources/new-call-instant/new-call-instant.mjs (1 hunks)
  • components/krispcall/sources/new-contact-instant/new-contact-instant.mjs (1 hunks)
  • components/krispcall/sources/new-sms-or-mms-instant/new-sms-or-mms-instant.mjs (1 hunks)
  • components/krispcall/sources/new-voicemail-instant/new-voicemail-instant.mjs (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (4)
  • GitHub Check: pnpm publish
  • GitHub Check: Verify TypeScript components
  • GitHub Check: Publish TypeScript components
  • GitHub Check: Lint Code Base
🔇 Additional comments (9)
components/krispcall/actions/new-mms/new-mms.mjs (1)

7-7: Approve version increment for Send New MMS action.
The metadata version bump from “0.0.3” to “0.0.4” is consistent with the coordinated release across KrispCall actions.

components/krispcall/actions/delete-contact/delete-contact.mjs (1)

8-8: Approve version increment for Delete Contact action.
Updating the version to “0.0.4” matches the other action modules’ patch-level bump.

components/krispcall/actions/new-sms/new-sms.mjs (1)

7-7: Approve version increment for Send New SMS action.
The change from “0.0.3” to “0.0.4” is correct and aligns with the overall version sync.

components/krispcall/sources/new-call-instant/new-call-instant.mjs (1)

9-9: Approve version increment for New Call (Instant) source.
Bumping from “0.0.1” to “0.0.2” aligns with the patch-level version updates across sources and actions.

components/krispcall/sources/new-contact-instant/new-contact-instant.mjs (1)

9-9: Approve version bump to 0.0.4
The patch correctly updates the component’s version from 0.0.30.0.4, keeping it in sync with the coordinated release.

components/krispcall/actions/add-contact/add-contact.mjs (1)

7-7: Approve version bump to 0.0.4
The action’s version increment aligns with corresponding updates in other KrispCall components and the package.

components/krispcall/sources/new-sms-or-mms-instant/new-sms-or-mms-instant.mjs (1)

9-9: Approve version bump to 0.0.4
This source component’s version is now consistent with the rest of the integration’s coordinated patch release.

components/krispcall/package.json (1)

3-3: Approve package version bump to 0.2.1
Updating the package’s version to 0.2.1 correctly reflects the cumulative component releases targeting production readiness.

components/krispcall/sources/new-voicemail-instant/new-voicemail-instant.mjs (1)

9-9: Approve version bump to 0.0.4
The voicemail source’s version increment matches the patch-level update across all KrispCall components.

@GTFalcao GTFalcao merged commit 09c3714 into master May 13, 2025
11 checks passed
@GTFalcao GTFalcao deleted the issue-16633 branch May 13, 2025 01:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Krispcall
2 participants