-
Notifications
You must be signed in to change notification settings - Fork 5.3k
Adding components to rate limit #16650
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 3 Skipped Deployments
|
WalkthroughThe documentation for Pipedream Connect's API was updated to correct the endpoint from Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant API Documentation
User->>API Documentation: Reads rate limits for endpoints
API Documentation-->>User: Shows corrected endpoint and new /components rate limit
Possibly related PRs
Poem
Tip ⚡️ Faster reviews with caching
Enjoy the performance boost—your workflow just got faster. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
docs-v2/pages/connect/api.mdx (1)
151-151
: New/components
rate limit entry looks good
The addition of a 300 rpm limit per project for all/components/*
endpoints (including/components
,/actions
, and/triggers
) provides necessary clarity. Consider adding the HTTP method (e.g.,GET
) for consistency with other table entries or a brief note on which operations the limit applies to if they vary.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
docs-v2/pages/connect/api.mdx
(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (2)
- GitHub Check: validate-links
- GitHub Check: Lint Code Base
🔇 Additional comments (1)
docs-v2/pages/connect/api.mdx (1)
149-149
: Endpoint correction approved
The change fromPOST /tokens
toPOST /token
accurately reflects the actual API and aligns with upstream usage.
WHY
Summary by CodeRabbit
POST /tokens
toPOST /token
./components
endpoint, specifying a limit of 300 requests per minute per project, covering all related endpoints.