clippy

pyo3-macros-backend/src/attributes.rs

@@ -379,8 +379,8 @@ pub fn get_pyo3_options<T: Parse>(attr: &syn::Attribute) -> Result<Option<Punctu
 /// (In `retain`, returning `true` keeps the element, here it removes it.)
 pub fn take_attributes(
     attrs: &mut Vec<Attribute>,
-    mut extractor: impl FnMut(&Attribute) -> syn::Result<bool>,
-) -> syn::Result<()> {
+    mut extractor: impl FnMut(&Attribute) -> Result<bool>,
+) -> Result<()> {
     *attrs = attrs
         .drain(..)
         .filter_map(|attr| {
@@ -392,7 +392,7 @@ pub fn take_attributes(
     Ok(())
 }
 
-pub fn take_pyo3_options<T: Parse>(attrs: &mut Vec<syn::Attribute>) -> syn::Result<Vec<T>> {
+pub fn take_pyo3_options<T: Parse>(attrs: &mut Vec<syn::Attribute>) -> Result<Vec<T>> {
     let mut out = Vec::new();
 
     take_attributes(attrs, |attr| match get_pyo3_options(attr) {

pyo3-macros-backend/src/combine_errors.rs

@@ -1,5 +1,3 @@
-use syn;
-
 pub(crate) trait CombineErrors: Iterator {
     type Ok;
     fn try_combine_syn_errors(self) -> syn::Result<impl Iterator<Item = Self::Ok>>;

pyo3-macros-backend/src/module.rs

@@ -159,7 +159,7 @@ pub fn pymodule_module_impl(
     let mut module_consts = Vec::new();
     let mut module_consts_cfg_attrs = Vec::new();
 
-    let _: Vec<()> = (&mut *items).into_iter().map(|item|{
+    let _: Vec<()> = (&mut *items).iter_mut().map(|item|{
         match item {
             Item::Use(item_use) => {
                 let is_pymodule_export =

pyo3-macros-backend/src/pyimpl.rs

@@ -124,7 +124,7 @@ pub fn impl_methods(
     let mut implemented_proto_fragments = HashSet::new();
 
     let _: Vec<()> = impls
-        .into_iter()
+        .iter_mut()
         .map(|iimpl| {
             match iimpl {
                 syn::ImplItem::Fn(meth) => {