Skip to content

tests: integration tests for boot mode #664

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 9, 2025

Conversation

marmarek
Copy link
Member

Right now they mostly duplicate what unit tests are already testing. It
will make more sense for boot mode with in-vm kernel, and/or Whonix
package (instead of dummy boot modes).

QubesOS/qubes-issues#9750

Related to #653
FYI @ArrayBolt3

Copy link

codecov bot commented Feb 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.90%. Comparing base (9a89893) to head (c402256).
Report is 15 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #664      +/-   ##
==========================================
+ Coverage   69.75%   69.90%   +0.15%     
==========================================
  Files          58       59       +1     
  Lines       12550    12612      +62     
==========================================
+ Hits         8754     8817      +63     
+ Misses       3796     3795       -1     
Flag Coverage Δ
unittests 69.90% <ø> (+0.15%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@marmarek marmarek force-pushed the bootmode-integ-test branch from 27b725e to 54f42ba Compare February 27, 2025 13:23
@marmarek
Copy link
Member Author

So, the test said = is not allowed in feature request values... PR incoming

@qubesos-bot
Copy link

qubesos-bot commented Feb 27, 2025

OpenQA test summary

Complete test suite and dependencies: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2025030800-4.3&flavor=pull-requests

Test run included the following:

New failures, excluding unstable

Compared to: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2025021804-4.3&flavor=update

Failed tests

25 failures
  • system_tests_whonix

    • whonixcheck: fail (unknown)
      Whonixcheck for anon-whonix failed...

    • whonixcheck: unnamed test (unknown)

    • whonixcheck: fail (unknown)
      Whonixcheck for whonix-gateway-17 failed...

    • whonixcheck: unnamed test (unknown)

    • whonixcheck: fail (unknown)
      Whonixcheck for sys-whonix failed...

    • whonixcheck: unnamed test (unknown)

    • whonixcheck: fail (unknown)
      Whonixcheck for whonix-workstation-17 failed...

    • whonixcheck: unnamed test (unknown)

  • system_tests_suspend

    • suspend: unnamed test (unknown)
    • suspend: Failed (test died)
      # Test died: no candidate needle with tag(s) 'SUSPEND-FAILED' match...
  • system_tests_qrexec

    • TC_00_Qrexec_whonix-workstation-17: test_065_qrexec_exit_code_vm (failure)
      ~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^... AssertionError: b'125\n' != b'0\n'
  • system_tests_devices

    • TC_00_List_whonix-gateway-17: test_001_list_loop_mounted (failure)
      AssertionError: Device test-inst-vm:loop0::0 (/tmp/test.img) should...
  • system_tests_audio@hw1

  • system_tests_whonix@hw7

    • whonixcheck: fail (unknown)
      Whonixcheck for anon-whonix failed...

    • whonixcheck: unnamed test (unknown)

    • whonixcheck: fail (unknown)
      Whonixcheck for whonix-gateway-17 failed...

    • whonixcheck: unnamed test (unknown)

    • whonixcheck: fail (unknown)
      Whonixcheck for sys-whonix failed...

    • whonixcheck: unnamed test (unknown)

    • whonixcheck: fail (unknown)
      Whonixcheck for whonix-workstation-17 failed...

    • whonixcheck: unnamed test (unknown)

  • system_tests_suspend@hw1

    • suspend: unnamed test (unknown)
    • suspend: Failed (test died)
      # Test died: no candidate needle with tag(s) 'SUSPEND-FAILED' match...
  • system_tests_kde_gui_interactive

    • gui_filecopy: unnamed test (unknown)
    • gui_filecopy: Failed (test died)
      # Test died: no candidate needle with tag(s) 'files-work' matched...

Fixed failures

Compared to: https://openqa.qubes-os.org/tests/129058#dependencies

9 fixed
  • system_tests_whonix

  • system_tests_qrexec

  • system_tests_audio

  • system_tests_basic_vm_qrexec_gui_btrfs

    • TC_03_QvmRevertTemplateChanges: test_000_revert_linux (error)
      subprocess.CalledProcessError: Command '['sha1sum', '/var/lib/qubes...
  • system_tests_whonix@hw7

  • system_tests_kde_gui_interactive

    • clipboard_and_web: unnamed test (unknown)
    • clipboard_and_web: Failed (test died)
      # Test died: no candidate needle with tag(s) 'clipboard-paste-notif...

Unstable tests

Performance Tests

Performance degradation:

32 performance degradations
  • debian-12-xfce_exec-data-simplex: 66.55 :small_red_triangle_up: ( previous job: 48.93, degradation: 136.01%)
  • debian-12-xfce_exec-data-duplex: 70.59 :small_red_triangle_up: ( previous job: 50.76, degradation: 139.06%)
  • debian-12-xfce_exec-data-duplex-root: 84.38 :small_red_triangle_up: ( previous job: 64.91, degradation: 130.01%)
  • debian-12-xfce_socket-data-duplex: 161.85 :small_red_triangle_up: ( previous job: 81.49, degradation: 198.62%)
  • fedora-41-xfce_exec-data-simplex: 66.95 :small_red_triangle_up: ( previous job: 49.65, degradation: 134.85%)
  • fedora-41-xfce_exec-data-duplex: 65.33 :small_red_triangle_up: ( previous job: 49.08, degradation: 133.10%)
  • fedora-41-xfce_exec-data-duplex-root: 95.70 :small_red_triangle_up: ( previous job: 81.65, degradation: 117.21%)
  • fedora-41-xfce_socket-data-duplex: 155.32 :small_red_triangle_up: ( previous job: 78.62, degradation: 197.55%)
  • whonix-gateway-17_socket: 8.46 :small_red_triangle_up: ( previous job: 7.54, degradation: 112.18%)
  • whonix-gateway-17_exec-data-simplex: 77.38 :small_red_triangle_up: ( previous job: 48.76, degradation: 158.67%)
  • whonix-gateway-17_exec-data-duplex: 74.40 :small_red_triangle_up: ( previous job: 48.55, degradation: 153.22%)
  • whonix-gateway-17_exec-data-duplex-root: 93.71 :small_red_triangle_up: ( previous job: 70.13, degradation: 133.62%)
  • whonix-gateway-17_socket-data-duplex: 165.57 :small_red_triangle_up: ( previous job: 82.74, degradation: 200.11%)
  • whonix-workstation-17_exec-data-simplex: 70.78 :small_red_triangle_up: ( previous job: 47.01, degradation: 150.55%)
  • whonix-workstation-17_exec-data-duplex: 75.62 :small_red_triangle_up: ( previous job: 49.48, degradation: 152.84%)
  • whonix-workstation-17_exec-data-duplex-root: 107.08 :small_red_triangle_up: ( previous job: 79.93, degradation: 133.97%)
  • whonix-workstation-17_socket-data-duplex: 161.75 :small_red_triangle_up: ( previous job: 81.71, degradation: 197.95%)
  • dom0_root_seq1m_q8t1_read 3:read_bandwidth_kb: 431868.00 :small_red_triangle_up: ( previous job: 486352.00, degradation: 88.80%)
  • dom0_root_seq1m_q8t1_write 3:write_bandwidth_kb: 114612.00 :small_red_triangle_up: ( previous job: 276742.00, degradation: 41.41%)
  • dom0_root_seq1m_q1t1_read 3:read_bandwidth_kb: 209757.00 :small_red_triangle_up: ( previous job: 423495.00, degradation: 49.53%)
  • dom0_root_seq1m_q1t1_write 3:write_bandwidth_kb: 75040.00 :small_red_triangle_up: ( previous job: 185030.00, degradation: 40.56%)
  • dom0_root_rnd4k_q1t1_read 3:read_bandwidth_kb: 8727.00 :small_red_triangle_up: ( previous job: 10163.00, degradation: 85.87%)
  • dom0_varlibqubes_seq1m_q1t1_write 3:write_bandwidth_kb: 145030.00 :small_red_triangle_up: ( previous job: 164133.00, degradation: 88.36%)
  • dom0_varlibqubes_rnd4k_q32t1_write 3:write_bandwidth_kb: 7701.00 :small_red_triangle_up: ( previous job: 8767.00, degradation: 87.84%)
  • fedora-41-xfce_root_seq1m_q1t1_read 3:read_bandwidth_kb: 287833.00 :small_red_triangle_up: ( previous job: 343795.00, degradation: 83.72%)
  • fedora-41-xfce_root_rnd4k_q32t1_write 3:write_bandwidth_kb: 2621.00 :small_red_triangle_up: ( previous job: 3785.00, degradation: 69.25%)
  • fedora-41-xfce_root_rnd4k_q1t1_write 3:write_bandwidth_kb: 872.00 :small_red_triangle_up: ( previous job: 1126.00, degradation: 77.44%)
  • fedora-41-xfce_private_rnd4k_q1t1_write 3:write_bandwidth_kb: 1090.00 :small_red_triangle_up: ( previous job: 1613.00, degradation: 67.58%)
  • fedora-41-xfce_volatile_seq1m_q8t1_read 3:read_bandwidth_kb: 347210.00 :small_red_triangle_up: ( previous job: 392725.00, degradation: 88.41%)
  • fedora-41-xfce_volatile_seq1m_q8t1_write 3:write_bandwidth_kb: 109191.00 :small_red_triangle_up: ( previous job: 139933.00, degradation: 78.03%)
  • fedora-41-xfce_volatile_rnd4k_q32t1_write 3:write_bandwidth_kb: 2343.00 :small_red_triangle_up: ( previous job: 3959.00, degradation: 59.18%)
  • fedora-41-xfce_volatile_rnd4k_q1t1_write 3:write_bandwidth_kb: 1835.00 :small_red_triangle_up: ( previous job: 2693.00, degradation: 68.14%)

Remaining performance tests:

40 tests
  • debian-12-xfce_exec: 7.13 🟢 ( previous job: 7.15, improvement: 99.62%)
  • debian-12-xfce_exec-root: 29.01 :small_red_triangle_up: ( previous job: 27.97, degradation: 103.72%)
  • debian-12-xfce_socket: 7.97 🟢 ( previous job: 8.33, improvement: 95.73%)
  • debian-12-xfce_socket-root: 8.84 :small_red_triangle_up: ( previous job: 8.20, degradation: 107.80%)
  • fedora-41-xfce_exec: 9.27 :small_red_triangle_up: ( previous job: 9.13, degradation: 101.45%)
  • fedora-41-xfce_exec-root: 63.98 :small_red_triangle_up: ( previous job: 61.17, degradation: 104.59%)
  • fedora-41-xfce_socket: 8.85 :small_red_triangle_up: ( previous job: 8.66, degradation: 102.15%)
  • fedora-41-xfce_socket-root: 8.46 🟢 ( previous job: 8.61, improvement: 98.31%)
  • whonix-gateway-17_exec: 6.89 🟢 ( previous job: 7.87, improvement: 87.64%)
  • whonix-gateway-17_exec-root: 41.09 :small_red_triangle_up: ( previous job: 38.36, degradation: 107.09%)
  • whonix-gateway-17_socket-root: 7.59 🟢 ( previous job: 8.27, improvement: 91.75%)
  • whonix-workstation-17_exec: 7.68 🟢 ( previous job: 8.23, improvement: 93.26%)
  • whonix-workstation-17_exec-root: 57.58 :small_red_triangle_up: ( previous job: 52.56, degradation: 109.55%)
  • whonix-workstation-17_socket: 8.81 :small_red_triangle_up: ( previous job: 8.21, degradation: 107.35%)
  • whonix-workstation-17_socket-root: 7.69 🟢 ( previous job: 8.20, improvement: 93.81%)
  • dom0_root_rnd4k_q32t1_read 3:read_bandwidth_kb: 100714.00 :green_circle: ( previous job: 100699.00, improvement: 100.01%)
  • dom0_root_rnd4k_q32t1_write 3:write_bandwidth_kb: 5794.00 :green_circle: ( previous job: 3277.00, improvement: 176.81%)
  • dom0_root_rnd4k_q1t1_write 3:write_bandwidth_kb: 2640.00 :green_circle: ( previous job: 282.00, improvement: 936.17%)
  • dom0_varlibqubes_seq1m_q8t1_read 3:read_bandwidth_kb: 500991.00 :green_circle: ( previous job: 475329.00, improvement: 105.40%)
  • dom0_varlibqubes_seq1m_q8t1_write 3:write_bandwidth_kb: 233068.00 :green_circle: ( previous job: 95209.00, improvement: 244.80%)
  • dom0_varlibqubes_seq1m_q1t1_read 3:read_bandwidth_kb: 404543.00 :small_red_triangle_up: ( previous job: 433474.00, degradation: 93.33%)
  • dom0_varlibqubes_rnd4k_q32t1_read 3:read_bandwidth_kb: 95544.00 :small_red_triangle_up: ( previous job: 99808.00, degradation: 95.73%)
  • dom0_varlibqubes_rnd4k_q1t1_read 3:read_bandwidth_kb: 8027.00 :green_circle: ( previous job: 7053.00, improvement: 113.81%)
  • dom0_varlibqubes_rnd4k_q1t1_write 3:write_bandwidth_kb: 3806.00 :small_red_triangle_up: ( previous job: 3868.00, degradation: 98.40%)
  • fedora-41-xfce_root_seq1m_q8t1_read 3:read_bandwidth_kb: 386928.00 :small_red_triangle_up: ( previous job: 396586.00, degradation: 97.56%)
  • fedora-41-xfce_root_seq1m_q8t1_write 3:write_bandwidth_kb: 256312.00 :green_circle: ( previous job: 99783.00, improvement: 256.87%)
  • fedora-41-xfce_root_seq1m_q1t1_write 3:write_bandwidth_kb: 97776.00 :green_circle: ( previous job: 44770.00, improvement: 218.40%)
  • fedora-41-xfce_root_rnd4k_q32t1_read 3:read_bandwidth_kb: 82730.00 :small_red_triangle_up: ( previous job: 86742.00, degradation: 95.37%)
  • fedora-41-xfce_root_rnd4k_q1t1_read 3:read_bandwidth_kb: 8427.00 :small_red_triangle_up: ( previous job: 8623.00, degradation: 97.73%)
  • fedora-41-xfce_private_seq1m_q8t1_read 3:read_bandwidth_kb: 416266.00 :green_circle: ( previous job: 401907.00, improvement: 103.57%)
  • fedora-41-xfce_private_seq1m_q8t1_write 3:write_bandwidth_kb: 112158.00 :small_red_triangle_up: ( previous job: 116848.00, degradation: 95.99%)
  • fedora-41-xfce_private_seq1m_q1t1_read 3:read_bandwidth_kb: 323135.00 :small_red_triangle_up: ( previous job: 357875.00, degradation: 90.29%)
  • fedora-41-xfce_private_seq1m_q1t1_write 3:write_bandwidth_kb: 40341.00 :small_red_triangle_up: ( previous job: 41375.00, degradation: 97.50%)
  • fedora-41-xfce_private_rnd4k_q32t1_read 3:read_bandwidth_kb: 83103.00 :small_red_triangle_up: ( previous job: 87999.00, degradation: 94.44%)
  • fedora-41-xfce_private_rnd4k_q32t1_write 3:write_bandwidth_kb: 4117.00 :green_circle: ( previous job: 3885.00, improvement: 105.97%)
  • fedora-41-xfce_private_rnd4k_q1t1_read 3:read_bandwidth_kb: 8013.00 :small_red_triangle_up: ( previous job: 8744.00, degradation: 91.64%)
  • fedora-41-xfce_volatile_seq1m_q1t1_read 3:read_bandwidth_kb: 304199.00 :green_circle: ( previous job: 294875.00, improvement: 103.16%)
  • fedora-41-xfce_volatile_seq1m_q1t1_write 3:write_bandwidth_kb: 83237.00 :green_circle: ( previous job: 78093.00, improvement: 106.59%)
  • fedora-41-xfce_volatile_rnd4k_q32t1_read 3:read_bandwidth_kb: 81375.00 :green_circle: ( previous job: 71108.00, improvement: 114.44%)
  • fedora-41-xfce_volatile_rnd4k_q1t1_read 3:read_bandwidth_kb: 8273.00 :small_red_triangle_up: ( previous job: 8408.00, degradation: 98.39%)

@marmarek marmarek force-pushed the bootmode-integ-test branch from 54f42ba to 8b3a030 Compare February 27, 2025 21:07
@marmarek marmarek force-pushed the bootmode-integ-test branch from 8b3a030 to fcca635 Compare March 2, 2025 23:48
Right now they mostly duplicate what unit tests are already testing. It
will make more sense for boot mode with in-vm kernel, and/or Whonix
package (instead of dummy boot modes).

QubesOS/qubes-issues#9750
@marmarek
Copy link
Member Author

marmarek commented Mar 9, 2025

@ArrayBolt3 I'll also merge this one as is. It did found some issues that unit tests missed before, so IMO it's still useful (even though duplicates some parts). And later it can be extended to test in-vm kernel support.

@marmarek marmarek merged commit 54527f8 into QubesOS:main Mar 9, 2025
4 of 5 checks passed
@marmarek marmarek deleted the bootmode-integ-test branch March 16, 2025 01:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants