-
-
Notifications
You must be signed in to change notification settings - Fork 119
qubes-firewall: Suppress extraneous conntrack output #553
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #553 +/- ##
=======================================
Coverage 70.14% 70.14%
=======================================
Files 3 3
Lines 469 469
=======================================
Hits 329 329
Misses 140 140 ☔ View full report in Codecov by Sentry. |
conntrack generally prints a status message to stderr before exiting, which interferes with listing connections. Output from dropping connections was unused. Fixes QubesOS/qubes-issues#9760
207c424
to
d8fb353
Compare
OpenQA test summaryComplete test suite and dependencies: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2025021317-4.3&flavor=pull-requests Test run included the following:
New failures, excluding unstableCompared to: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2025020404-4.3&flavor=update
Failed tests86 failures
Fixed failuresCompared to: https://openqa.qubes-os.org/tests/127852#dependencies 30 fixed
Unstable testsPerformance TestsPerformance degradation:No issues Remaining performance tests:52 tests
|
conntrack generally prints a status message to stderr before exiting, which interferes with listing connections. Output from dropping connections was unused.
Testing: developed within my
sys-firewall
, verified thatconntrack_get_connections
no longer observes lines containing "conntrack", and that connection dropping still works.Fixes QubesOS/qubes-issues#9760