Skip to content

archlinux: Sync /etc/fstab with other distros #575

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 30, 2025

Conversation

marmarek
Copy link
Member

The custom persist feature relies on /home etc not being in /etc/fstab anymore.
See commit messages for details.

Fixes QubesOS/qubes-issues#9975

marmarek added 3 commits May 27, 2025 21:49
/etc/fstab is (was) overriden by builder-archlinux anyway, so it was a
dead code already.
Install it as /etc/fstab, and replace the original in post-install hook,
but only if it wasn't qubes one already. This way, user modifications
are not overridden.

QubesOS/qubes-issues#9975
Custom persist update removed those entries from /etc/fstab file as
packaged, but Arch package was "special" and didn't used this file before.
Apply the update in post-update hook.

Fixes: 6e7bed0 "custom-persist: systemd mount units ..."
Fixes QubesOS/qubes-issues#9975
Copy link

codecov bot commented May 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.68%. Comparing base (a3ae1b0) to head (aff3c5c).
Report is 7 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #575      +/-   ##
==========================================
- Coverage   71.10%   70.68%   -0.42%     
==========================================
  Files           3        3              
  Lines         481      481              
==========================================
- Hits          342      340       -2     
- Misses        139      141       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@qubesos-bot
Copy link

qubesos-bot commented May 28, 2025

OpenQA test summary

Complete test suite and dependencies: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2025052914-4.3-archlinux&flavor=templates

Test run included the following:

New failures, excluding unstable

Compared to: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2025031804-4.3&flavor=update

  • system_tests_whonix

    • whonix_torbrowser: unnamed test (unknown)
    • whonix_torbrowser: Failed (test died)
      # Test died: no candidate needle with tag(s) 'anon-whonix-tor-brows...
  • system_tests_audio

  • system_tests_guivm_gui_interactive

    • update_templates: Failed (test died)
      # Test died: command 'qvm-template upgrade --yes --enablerepo=qubes...
  • system_tests_gui_interactive

    • clipboard_and_web: unnamed test (unknown)
    • clipboard_and_web: Failed (test died)
      # Test died: no candidate needle with tag(s) 'text-editor-save-prom...

Failed tests

9 failures
  • system_tests_whonix

    • whonix_torbrowser: unnamed test (unknown)
    • whonix_torbrowser: Failed (test died)
      # Test died: no candidate needle with tag(s) 'anon-whonix-tor-brows...
  • system_tests_audio

  • system_tests_guivm_gui_interactive

    • update_templates: Failed (test died)
      # Test died: command 'qvm-template upgrade --yes --enablerepo=qubes...
  • system_tests_gui_interactive

    • clipboard_and_web: unnamed test (unknown)
    • clipboard_and_web: Failed (test died)
      # Test died: no candidate needle with tag(s) 'text-editor-save-prom...

Fixed failures

Compared to: https://openqa.qubes-os.org/tests/132953#dependencies

5 fixed

Unstable tests

  • system_tests_update

    update2/Failed (1/5 times with errors)
    • job 139051 # Test died: command 'script -c 'qubes-vm-update --force-update --l...

Performance Tests

Performance degradation:

No issues

Remaining performance tests:

No remaining performance tests

@marmarek marmarek merged commit b28c3b0 into QubesOS:main May 30, 2025
3 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

test_020_custom_persist fails on Archlinux
2 participants