Skip to content

Add Debug Console to Qui Domains systray widget #249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 17, 2025

Conversation

alimirjamali
Copy link

@alimirjamali alimirjamali marked this pull request as draft February 28, 2025 20:25
Copy link

@ben-grande ben-grande left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks nice!

As you said:

It lacks property change and feature change watches for live changes. It also lacks unittests.

@alimirjamali alimirjamali force-pushed the issue-9788-debug-console branch from 41e9135 to 1cda417 Compare March 6, 2025 11:09
Copy link

codecov bot commented Mar 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.67%. Comparing base (33fd435) to head (203be8c).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #249      +/-   ##
==========================================
- Coverage   92.68%   92.67%   -0.01%     
==========================================
  Files          59       59              
  Lines       11267    11267              
==========================================
- Hits        10443    10442       -1     
- Misses        824      825       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@alimirjamali alimirjamali force-pushed the issue-9788-debug-console branch from 1cda417 to e9f9f7e Compare March 13, 2025 21:20
@alimirjamali alimirjamali requested a review from ben-grande March 13, 2025 21:21
@alimirjamali
Copy link
Author

Thanks, looks nice!

As you said:

It lacks property change and feature change watches for live changes. It also lacks unittests.

Event watches are added. It will react live to debug and guivm property changes as well as wizard-mode feature change (per VM & per entire GUIVM). The entire Domain widget does not appear to have a unittest (most probably only openQA integrity tests).

And I changed the icon to be inline with the Debug Console icon of VM submenus while shutting them down.

@alimirjamali alimirjamali marked this pull request as ready for review March 13, 2025 21:25
@alimirjamali alimirjamali force-pushed the issue-9788-debug-console branch from e9f9f7e to 3b6d88b Compare March 14, 2025 09:57
Copy link

@ben-grande ben-grande left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, check the pylint and black complaints on Gitlab CI.

@alimirjamali alimirjamali force-pushed the issue-9788-debug-console branch 3 times, most recently from f965d8c to fe79cbc Compare March 14, 2025 12:41
@alimirjamali
Copy link
Author

LGTM, check the pylint and black complaints on Gitlab CI.

I had to override show event for Debug Console menu item because of cascading show_all calls to its parent. The pylint and black checks should be green again.

The Icon image is reverted to 16x16 again as the menu code does not convert it to an auto scaling icon automatically (this is honestly a bug of existing code which should be tested on HiDPI screens and fixed separately).

@alimirjamali alimirjamali force-pushed the issue-9788-debug-console branch 2 times, most recently from 2622804 to fd030cf Compare March 14, 2025 21:03
@marmarek
Copy link
Member

This needs a rebase

@alimirjamali alimirjamali force-pushed the issue-9788-debug-console branch 2 times, most recently from e303377 to dddf91d Compare March 16, 2025 07:22
@alimirjamali
Copy link
Author

This needs a rebase

Rebase is done

@alimirjamali alimirjamali force-pushed the issue-9788-debug-console branch from fbf5050 to 203be8c Compare March 31, 2025 21:05
@marmarek marmarek merged commit 203be8c into QubesOS:main Apr 17, 2025
4 of 5 checks passed
@ben-grande
Copy link

Thanks @alimirjamali !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Management console is hard to find
5 participants