-
-
Notifications
You must be signed in to change notification settings - Fork 43
Add Debug Console to Qui Domains systray widget #249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, looks nice!
As you said:
It lacks property change and feature change watches for live changes. It also lacks unittests.
41e9135
to
1cda417
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #249 +/- ##
==========================================
- Coverage 92.68% 92.67% -0.01%
==========================================
Files 59 59
Lines 11267 11267
==========================================
- Hits 10443 10442 -1
- Misses 824 825 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
1cda417
to
e9f9f7e
Compare
Event watches are added. It will react live to And I changed the icon to be inline with the Debug Console icon of VM submenus while shutting them down. |
e9f9f7e
to
3b6d88b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, check the pylint and black complaints on Gitlab CI.
f965d8c
to
fe79cbc
Compare
I had to override The Icon image is reverted to 16x16 again as the menu code does not convert it to an auto scaling icon automatically (this is honestly a bug of existing code which should be tested on HiDPI screens and fixed separately). |
2622804
to
fd030cf
Compare
This needs a rebase |
e303377
to
dddf91d
Compare
Rebase is done |
fbf5050
to
203be8c
Compare
Thanks @alimirjamali ! |
fixes: QubesOS/qubes-issues#9788