Center Global Config after window resize #250
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #250 +/- ##
==========================================
+ Coverage 93.16% 93.25% +0.09%
==========================================
Files 58 58
Lines 11065 11140 +75
==========================================
+ Hits 10309 10389 +80
+ Misses 756 751 -5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This was referenced Mar 13, 2025
Merged
OpenQA test summaryComplete test suite and dependencies: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2025031619-4.3&flavor=pull-requests Test run included the following:
New failures, excluding unstableCompared to: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2025021804-4.3&flavor=update
Failed tests15 failures
Fixed failuresCompared to: https://openqa.qubes-os.org/tests/129058#dependencies 6 fixed
Unstable testsPerformance TestsPerformance degradation:30 performance degradations
Remaining performance tests:42 tests
|
This was referenced Mar 13, 2025
Merged
Merged
marmarta
approved these changes
Mar 14, 2025
|
Hm, on testing, this also happens when the user has deliberately moved the window to a certain position and then resizes, which can be annoying. I'm on the fence here :/ |
alimirjamali
force-pushed
the
center_global_config
branch
from
1345c1f to
0741dc1
Compare
Moved the simple positioning from Glade file to the code and did some Gdk tricks. It works well on XFCE as intended. I do not have KDE installed at the moment to see how it behaves there. I hope you could check (maybe via VNC connection to testing facilities). |
Assure Global Config window will remain on the center of the screen after window is resized.
alimirjamali
force-pushed
the
center_global_config
branch
from
0741dc1 to
ae554b3
Compare
marmarek
approved these changes
Mar 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Assure Global Config window will remain on the center of the screen after window is resized.