Skip to content

Add Heads certified firmware option for NovaCustom V54 & V56 #1473

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 20, 2025

Conversation

andrewdavidwong
Copy link
Member

@andrewdavidwong andrewdavidwong commented May 16, 2025

Copy link
Member

@marmarek marmarek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Approved as of caffc06eaf6a87446a5fbad04bf3e2d4124ec9da
-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEEnYWYU8Ll1fIX9iss8yiUvpaEk4oFAmgr5tUACgkQ8yiUvpaE
k4o4Jw//SXVUSidZSA3pLeM/eVpuMCpb3ICRZuQhJRiwsaNfvU8/ERyoWzZ4pqGG
WbA/aFoZI0+OXe/TsC8zN3/ifuQkLxF9J3ZsYEsKlsZMQZM563YxIAJCIL24doPl
DSMbbTgUxMZDRMRJ4cc3sGHdiiz9lbV9VI+YPDLtM7nzA6EqMMcWqoGyMD75Hdbd
NpLCb02w24EILdli+nqceDtszJl8aQJ+c9ktOmQDWE/jTXKBkL5+N8QFLFjvn4XU
44NFf5UogNVqeulkcuJsgunOOd6x8XrhhegEkKcp0k7MTn6FM05N5C84+LscUzed
m/zjDn8pHfCBpWmLP7FpXm42kstlsCUt9UGQMfXi2udO59YxRCdvdeGqUMR+jjrh
aMOkH65s896XhvtqycQaYYoYtV6KJhA0uZrMFvvg32w24KQRzFAl/QGpMJL01o53
5S7+EbrBEUuiB5D0L5Vz3MUskeg7payXpINy/YNJqX64UDmQ+XcSrOvXLfbYiODt
BOaplJi0WL81K2j0fqOSsP/qbUk7hCiEGpygkLRtXRSwCq03lRgOGXO0gu6pjxgm
Ew9ZhoYNpbesyiuG3+uDY8oOGA8Kdf0Pljao3gxKCvbULQQqPvnD+ti1J5NBmcYe
+k+Ccp++ocHangkfLMcrOLzt+PlSObE/6/EWsAQoRN7933OPE54=
=K91N
-----END PGP SIGNATURE-----

@maiska maiska merged commit 3e3d5d3 into main May 20, 2025
1 check failed
@andrewdavidwong
Copy link
Member Author

andrewdavidwong commented May 21, 2025

@maiska: FYI, when I self-assign a PR, feel free to leave it open for me to merge. Sometimes I have to wait for something else to occur before I can merge it, and sometimes I need to merge it alongside something else (e.g., QubesOS/qubes-posts#144 in this case). No harm done in this case; just thought I'd mention it for future reference. :)

(I know I can use "draft" mode for PRs, but then some reviewers interpret that to mean that the PR isn't ready for them to review yet, so we get stuck in a loop where I'm waiting for them to review it before I unmark it as a draft, while they're waiting for me to unmark it as a draft before they review it. I realized that what I really wanted to convey was, "I will merge this PR myself after it passes review," and that's probably not what the "draft" mode is for. Rather, I realized that the "assignee" and "reviewer" properties are probably more appropriate to convey this.)

@andrewdavidwong andrewdavidwong deleted the novacustom-v5x-heads branch May 21, 2025 02:23
@maiska
Copy link
Contributor

maiska commented May 21, 2025

@andrewdavidwong noted! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants