Send icons for legacy X11 Apps #231
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OpenQA test summaryComplete test suite and dependencies: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2025060120-4.3&flavor=pull-requests Test run included the following:
New failures, excluding unstableCompared to: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2025031804-4.3&flavor=update
Failed tests8 failures
Fixed failuresCompared to: https://openqa.qubes-os.org/tests/132953#dependencies 14 fixed
Unstable tests
Performance TestsPerformance degradation:17 performance degradations
Remaining performance tests:39 tests
|
This was referenced May 30, 2025
Since very old X11 Apps (Xterm, Xcalc, Xlogo, Xclock, Xeyes, ...) do not have the `_NET_WM_ICON` Atom, revert to `WM_HINT` and extract icons and their transparency with that technology. This is mostly useful for Xterm fixes: QubesOS/qubes-issues#9973
|
Reason for amendment: While I could not find any program which uses 8bit/pixel pixel_mask (on Qubes OS 4.3 & Xfwm), It would be better to write the code for the hypothetical scenario and be safe than sorry. |
marmarek
requested changes
Jun 1, 2025
window-icon-updater/icon-sender
Outdated
| @@ -49,6 +52,7 @@ class IconRetriever(object): | |||
| self.conn = xcffib.connect() | |||
| self.setup = self.conn.get_setup() | |||
| self.root = self.setup.roots[0].root | |||
| self.display = Display() | |||
There was a problem hiding this comment.
Don't make the second X11 connection with another library, use XCB connection that is here already.
There was a problem hiding this comment.
Ok. I rewrote the entire patch using xcffib in another commit. I can squash the two commits into one commit. But I believe it might be a good idea to keep a history of Xlib patch. So in few years, if anyone looks at history, they can find out how it is done with either of the libraries.
Since xcffib is preferred over Xlib and the method for `_NET_WM_ICON` is already implemented via xcffib, rewrite the previous patch with xcffib related: QubesOS/qubes-issues#9973
This was referenced Jun 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since very old X11 Apps (Xterm, Xcalc, Xlogo, Xclock, Xeyes, ...) do not have the
_NET_WM_ICONAtom, revert toWM_HINTand extract icons and their transparency with that technology. This is mostly useful for Xtermfixes: QubesOS/qubes-issues#9973