devcontainer: Fixed Dev Containers setup #4556
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current setup for Dev Containers was not working, with multiple different errors. So, in order to restore its funcionality (and allow for things like linting and debugging), the following changes were made: - The Dockerfile was severely alterered. Now, the `docker-php-ext-enable` binary is installed before its usage, it points to the correct PHP binary, and we install Composer for for loading dev-dependencies later-on. - Moved the "postCreateCommand" section (defined on the `devcontainer.json` file) into its own script file (for a more readable experience) - On the post-creation script, moved the `xdebug.ini` to the correct directory (alongside the PHP-FPM bin), installed PHPUnit, PHPCodesniffer (and the 'PHP Compatibility' sniffer) with Composer on a global location, and changed owner of the `cache` directory - Changed VSCode-specific customization setting in order to point to the update some binary paths. Also made sure globally-installed composer packages binaries are accessible via PATHdocker-php-ext-enable
I have not used the dev container of RSS Bridge, but before this fix, it was for sure not working due in particular to missing packets. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current setup for Dev Containers was not working, with multiple different errors. So, in order to restore its functionality (and allow for things like linting and debugging), the following changes were made:
The Dockerfile was severely alterered. Now, the
docker-php-ext-enablebinary is installed before its usage, it points to the correct PHP binary, and we install Composer for for loading dev-dependencies later-on;Moved the "postCreateCommand" section (defined on the
devcontainer.jsonfile) into its own script file (for a more readable experience);On the post-creation script, moved the
xdebug.inito the correct directory (alongside the PHP-FPM bin), installed PHPUnit, PHPCodesniffer (and the 'PHP Compatibility' sniffer) with Composer on a global location, and changed owner of thecachedirectory;Changed VSCode-specific customization setting in order to point to the update some binary paths. Also made sure globally-installed composer packages binaries are accessible via PATH.
Closes #4223