Skip to content

Small Compatibility Fix for CUDA 12.8. #165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 17, 2025
Merged

Small Compatibility Fix for CUDA 12.8. #165

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
83a6a1f
Compatibility Fix for CUDA 12.8.
Schmiedium Mar 17, 2025
1ce6585
Logic mistake in the previous commit, tested this and it should work …
Schmiedium Mar 17, 2025
830face
formatting fixes
Schmiedium Mar 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Compatibility Fix for CUDA 12.8. 
The latest version of CUDA ships libnvvm with version 2.0, which fails the check for an appopriate version number. This commit fixes this so that 2.0 correctly passes the minimum version number check.
  • Loading branch information
@Schmiedium
Schmiedium committed Mar 17, 2025
commit 83a6a1fd7f7555677a26bf43ac094cfdf65bfa4f
2 changes: 1 addition & 1 deletion crates/rustc_codegen_nvvm/src/nvvm.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ pub fn codegen_bitcode_modules(
// make sure the nvvm version is high enough so users don't get confusing compilation errors.
let (major, minor) = nvvm::ir_version();

if minor < 6 || major < 1 {
if minor < 6 && major < 1 {
sess.dcx()
.fatal("rustc_codegen_nvvm requires at least libnvvm 1.6 (CUDA 11.2)");
}
Expand Down
Loading