rust: types: Add try_from_foreign() method
#1059
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
obeis
force-pushed
the
try-from-foreign
branch
2 times, most recently
from
5ff8680 to
534b8e8
Compare
ojeda
reviewed
Jan 22, 2024
|
Thanks! The commit should be signed (in the The commit message could perhaps also show how a user would look like (like one of the ones linked in the issue). Apart from that, it seems OK to submit it to the mailing list -- please see https://rust-for-linux.com/contributing. |
obeis
added a commit
to obeis/linux
that referenced
this pull request
Jan 22, 2024
Currently `ForeignOwnable::from_foreign()` only
works for non-null pointers for the existing
impls (e.g. Box, Arc). It may create a few
duplicate code like:
```rust
// `p` is a maybe null pointer
if p.is_null() {
None
} else {
Some(unsafe { T::from_foreign(p) })
}
``
Link: Rust-for-Linux#1059
Cc: Alice Ryhl <[email protected]>
Cc: Matt Gilbride <[email protected]>
Cc: Miguel Ojeda <[email protected]>
Signed-off-by: Obei Sideg <[email protected]>
obeis
added a commit
to obeis/linux
that referenced
this pull request
Jan 22, 2024
Currently `ForeignOwnable::from_foreign()` only
works for non-null pointers for the existing
impls (e.g. Box, Arc). It may create a few
duplicate code like:
```rust
// `p` is a maybe null pointer
if p.is_null() {
None
} else {
Some(unsafe { T::from_foreign(p) })
}
``
Link: Rust-for-Linux#1059
Cc: Alice Ryhl <[email protected]>
Cc: Matt Gilbride <[email protected]>
Cc: Miguel Ojeda <[email protected]>
Signed-off-by: Obei Sideg <[email protected]>
obeis
force-pushed
the
try-from-foreign
branch
from
8db06e6 to
c9eee6f
Compare
|
Looks good. Is there code in the tree that can use this right away or we'd have to wait for patches to get merged? |
obeis
force-pushed
the
try-from-foreign
branch
6 times, most recently
from
ef4a066 to
63eb0b3
Compare
Currently `ForeignOwnable::from_foreign()` only works for non-null
pointers for the existing impls (e.g. Box, Arc). It may create a few
duplicate code like:
```rust
// `p` is a maybe null pointer
if p.is_null() {
None
} else {
unsafe { Some(Self::from_foreign(ptr)) }
}
```
Add a `try_from_foreign()` method that will return `None` if `ptr`
is null, otherwise return `Some(from_foreign(ptr))`.
Link: Rust-for-Linux#1057
Signed-off-by: Obei Sideg <[email protected]>
Reviewed-by: Alice Ryhl <[email protected]>
Reviewed-by: Trevor Gross <[email protected]>
obeis
force-pushed
the
try-from-foreign
branch
from
63eb0b3 to
47b451f
Compare
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #1057