Skip to content

Setup java11 as default, home, path + misc fix #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 12, 2025

Conversation

xschildw
Copy link
Contributor

PR Checklist:
[ ] Describe and explain your intentions for this change
[ ] Setup pre-commit and run the validators (info in README.md)

route: GET /repos/{owner}/{repo}/actions/runners
owner: ${{ github.repository_owner }}
repo: ${{ needs.repo-name.outputs.name }}
route: GET /repos/${{ github.repository_owner }}/${{ needs.repo-name.outputs.name }}/actions/runners
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trying to fix warning in job.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From what I read the warning is a known issue. I don't think you can fix it.

@xschildw xschildw requested a review from brucehoff June 11, 2025 23:15
Copy link
Member

@brucehoff brucehoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you need to run pre-commit run --all-files to fix some whitespace.

route: GET /repos/{owner}/{repo}/actions/runners
owner: ${{ github.repository_owner }}
repo: ${{ needs.repo-name.outputs.name }}
route: GET /repos/${{ github.repository_owner }}/${{ needs.repo-name.outputs.name }}/actions/runners
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From what I read the warning is a known issue. I don't think you can fix it.

@xschildw xschildw requested a review from brucehoff June 12, 2025 00:31
@xschildw xschildw merged commit b0668dc into main Jun 12, 2025
3 checks passed
@xschildw xschildw deleted the m-fix-migration-workflow branch June 12, 2025 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants