Skip to content

[py] Add missing 'id' property to ShadowRoot class #15739

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 15, 2025

Conversation

cgoldberg
Copy link
Contributor

@cgoldberg cgoldberg commented May 14, 2025

User description

🔗 Related Issues

Fixes #15734
Fixes #15732

💥 What does this PR do?

This PR adds an id property to the selenium.webdriver.remote.shadowroot.ShadowRoot class.

This attribute was missing and causing errors when trying to access shadow_root

🔄 Types of changes

  • Bug fix (backwards compatible)

PR Type

Bug fix


Description

  • Add missing id property to ShadowRoot class

  • Fix errors when accessing shadow_root.id


Changes walkthrough 📝

Relevant files
Bug fix
shadowroot.py
Add `id` property to ShadowRoot class                                       

py/selenium/webdriver/remote/shadowroot.py

  • Added an id property to the ShadowRoot class
  • Ensures access to the shadow root's internal id
  • Addresses errors when accessing shadow_root.id
  • +4/-0     

    Need help?
  • Type /help how to ... in the comments thread for any questions about Qodo Merge usage.
  • Check out the documentation for more information.
  • @selenium-ci selenium-ci added the C-py Python Bindings label May 14, 2025
    Copy link
    Contributor

    PR Reviewer Guide 🔍

    Here are some key observations to aid the review process:

    ⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ No major issues detected

    Copy link
    Contributor

    qodo-merge-pro bot commented May 14, 2025

    PR Code Suggestions ✨

    No code suggestions found for the PR.

    @cgoldberg cgoldberg merged commit 128ba0e into SeleniumHQ:trunk May 15, 2025
    15 of 17 checks passed
    @cgoldberg cgoldberg deleted the add-shadowroot-id branch May 15, 2025 00:46
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    re-opening issue regarding shadowDOM access [🐛 Bug]: Issue with shadowroot access
    2 participants