-
Notifications
You must be signed in to change notification settings - Fork 12
1679 setup end to end tests #1585
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: v2-development
Are you sure you want to change the base?
Conversation
…OpenJudgeSystem into 1679-setup-end-to-end-tests
…OpenJudgeSystem into 1679-setup-end-to-end-tests
…OpenJudgeSystem into 1679-setup-end-to-end-tests
…OpenJudgeSystem into 1679-setup-end-to-end-tests
@@ -1,5 +1,5 @@ | |||
/* eslint-disable import/no-unused-modules */ | |||
/* eslint-disable @typescript-eslint/no-non-null-assertion */ | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove these empty
lines.
@@ -9,11 +9,11 @@ import AdminApp from './AdminApp'; | |||
const container = document.getElementById('root'); | |||
const root = createRoot(container!); | |||
|
|||
const comp = ( | |||
const comp = |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use a more meaningful name here.
/* eslint-disable import/group-exports */ | ||
/* eslint-disable import/prefer-default-export */ | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove these empty
lines as well and in all the following files which have such empty
lines.
title="Transfer participants" | ||
text={( | ||
<span> | ||
{/* eslint-disable-next-line react/jsx-one-expression-per-line */} | ||
{ } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are these empty
brackets needed?
@@ -198,9 +197,9 @@ const ProblemResourceForm = (props :IProblemResourceFormProps) => { | |||
onChange={(e) => onChange(e)} | |||
/> | |||
</FormControl> | |||
); | |||
; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Keeping ;
on a new line does not look to good.
Closes https://github.com/SoftUni-Internal/exam-systems-issues/issues/1679
Summary of the changes made: