Submission Pull Request #54
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated xunit to 2.4.1 Updated xunit.runner.visualstudio to 2.4.1 Updated ccoverlet.collector to 1.2.0 Updated Microsoft.NET.Test.Sdk to 16.5.0
Project creation
…rrencies. Needs refinement.
Program scaffolding
Unit Tests completed. Some design flaws detected during coding. Will evaluate these and determine future course of action. CashRegister.Tender return should be looked at. It seems too static at this point. Money/Currency structure still needs works, and were somewhat difficult to setup good tests with their current design.
Initial structure and implementation completed.
Removed Currency "ToString" override and created "Display" method in the Tender Strategies interface. This eleviates the Currency from doing work that can be handled by the strategy and decouples the response from the model object.
Updated TenderStrategy Display method with LINQ for string building.
Added Preface text for console upon starting application.
Removed period from exact change response string.
Refactoring
Discovered equation for div/3 was incorrect Fixed equation
Random3 equation fix
Moved "standard" calculation to base class to remove coupling of inhe…
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have completed the Cash Register project as requested. I am sending this pull request for your evaluation. If there are any questions or comments, please contact me through my mobile number or email.
I appreciate this opportunity and l look forward to speaking with you in the near future.