Modify rule S5146: Adding education content for Micronaut (APPSEC-1783) #3968
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daniel-teuchert-sonarsource
requested changes
Jun 6, 2024
| @Get("/Noncompliant/httpresponse") | ||
| public HttpResponse<String> noncompliant(@QueryValue("q") String location) throws URISyntaxException { | ||
| URI url = new URI(location); | ||
| return HttpResponse.redirect(url); //Noncompliant |
There was a problem hiding this comment.
Suggested change
| return HttpResponse.redirect(url); //Noncompliant | |
| return HttpResponse.redirect(url); // Noncompliant |
| ---- | ||
| @Get("/Compliant/httpresponse") | ||
| public HttpResponse<String> compliant(@QueryValue("q") String location) throws URISyntaxException { | ||
| URI url = new URI(location.get()); |
There was a problem hiding this comment.
Suggested change
| URI url = new URI(location.get()); | |
| URI url = new URI(location); |
| public HttpResponse<String> compliant(@QueryValue("q") String location) throws URISyntaxException { | ||
| URI url = new URI(location.get()); | ||
| String host = url.getHost(); | ||
| if (host != null && host.endsWith(".example.com")) { |
There was a problem hiding this comment.
Same comment as in the PoC that this might still allow the redirection to a different port.
daniel-teuchert-sonarsource
approved these changes
Jun 6, 2024
Co-authored-by: daniel-teuchert-sonarsource <[email protected]>
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Review
A dedicated reviewer checked the rule description successfully for: